Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(232)

Issue 6867048: code review 6867048: go-tour: give each slide a unique name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 3 months ago by adg
Modified:
11 years, 3 months ago
Reviewers:
CC:
golang-dev, francesc
Visibility:
Public.

Description

go-tour: give each slide a unique name This will allow us to use human-readable fragments when linking to pages (eg, #methods instead of #37), make it easier to re-order slides, and store the code samples in separate go files.

Patch Set 1 #

Patch Set 2 : diff -r dcebd27953ee https://code.google.com/p/go-tour #

Total comments: 2

Patch Set 3 : diff -r f0759b1e1f52 https://code.google.com/p/go-tour #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -37 lines) Patch
M static/index.html View 1 22 chunks +25 lines, -37 lines 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go-tour
11 years, 3 months ago (2012-12-03 04:50:13 UTC) #1
francesc
Some comments, but anyway LGTM https://codereview.appspot.com/6867048/diff/2001/static/index.html File static/index.html (right): https://codereview.appspot.com/6867048/diff/2001/static/index.html#newcode401 static/index.html:401: <h2>For continued</h2> This sounds ...
11 years, 3 months ago (2012-12-04 00:27:15 UTC) #2
adg
11 years, 3 months ago (2012-12-04 00:36:56 UTC) #3
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=f46743ab58c3
***

go-tour: give each slide a unique name

This will allow us to use human-readable fragments when linking to
pages (eg, #methods instead of #37), make it easier to re-order slides,
and store the code samples in separate go files.

R=golang-dev, campoy
CC=golang-dev
https://codereview.appspot.com/6867048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b