Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1426)

Issue 6859043: code review 6859043: net: fix flaky test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dvyukov
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, bradfitz, dfc, mikio, remyoudompheng, rsc
Visibility:
Public.

Description

net: fix flaky test The test failed on one of the builders with: timeout_test.go:594: ln.Accept: accept tcp 127.0.0.1:19373: use of closed network connection http://build.golang.org/log/e83f4a152b37071b9d079096e15913811ad296b5

Patch Set 1 #

Patch Set 2 : diff -r d2b512689ae1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r d2b512689ae1 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 3

Patch Set 4 : diff -r 69e2f3d33300 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/pkg/net/timeout_test.go View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
11 years, 4 months ago (2012-11-26 19:15:07 UTC) #1
bradfitz
LGTM On Mon, Nov 26, 2012 at 11:15 AM, <dvyukov@google.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
11 years, 4 months ago (2012-11-26 20:29:40 UTC) #2
dfc
+mikioh I'm not sure why this works, Dial should not return until the connection has ...
11 years, 4 months ago (2012-11-26 20:51:40 UTC) #3
remyoudompheng
On 2012/11/26 <dave@cheney.net> wrote: > +mikioh > > I'm not sure why this works, Dial ...
11 years, 4 months ago (2012-11-26 21:08:13 UTC) #4
rsc
I believe Dial can return before the Accept executes. On most systems I believe that ...
11 years, 4 months ago (2012-11-26 21:09:46 UTC) #5
dfc
LGTM assuming the other comments are addressed. Sorry for being a stick in the mud ...
11 years, 4 months ago (2012-11-26 21:20:58 UTC) #6
bradfitz
On Mon, Nov 26, 2012 at 1:09 PM, Russ Cox <rsc@golang.org> wrote: > I believe ...
11 years, 4 months ago (2012-11-26 21:21:06 UTC) #7
remyoudompheng
On 2012/11/26 Brad Fitzpatrick <bradfitz@golang.org> wrote: > On Mon, Nov 26, 2012 at 1:09 PM, ...
11 years, 4 months ago (2012-11-26 21:25:51 UTC) #8
rsc
> Sorry for being a stick in the mud about this. I can see how, ...
11 years, 4 months ago (2012-11-26 21:50:01 UTC) #9
rsc
> Do that mean there's a possible series of packets I can throw at a ...
11 years, 4 months ago (2012-11-26 21:53:46 UTC) #10
bradfitz
On Mon, Nov 26, 2012 at 1:53 PM, Russ Cox <rsc@golang.org> wrote: > > Do ...
11 years, 4 months ago (2012-11-26 22:03:54 UTC) #11
rsc
> Yeah, I was just going on a tangent. Issue 3395 only fixed ECONNABORTED. > ...
11 years, 4 months ago (2012-11-26 22:10:43 UTC) #12
dvyukov
So, is this change LGTM? On Tue, Nov 27, 2012 at 2:10 AM, Russ Cox ...
11 years, 4 months ago (2012-11-27 05:49:41 UTC) #13
dfc
On 2012/11/27 05:49:41, dvyukov wrote: > So, is this change LGTM? > Yes.
11 years, 4 months ago (2012-11-27 06:10:01 UTC) #14
mikio
LGTM I couldn't repro the issue on freebsd/386 9.0-release but let's see what happens.
11 years, 4 months ago (2012-11-27 06:39:23 UTC) #15
dvyukov
11 years, 4 months ago (2012-11-27 08:24:20 UTC) #16
*** Submitted as http://code.google.com/p/go/source/detail?r=34e54cf71fed ***

net: fix flaky test
The test failed on one of the builders with:
timeout_test.go:594: 	ln.Accept: accept tcp 127.0.0.1:19373: use of closed
network connection
http://build.golang.org/log/e83f4a152b37071b9d079096e15913811ad296b5

R=golang-dev, bradfitz, dave, mikioh.mikioh, remyoudompheng, rsc
CC=golang-dev
http://codereview.appspot.com/6859043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b