environs/config: more tests for default-series

environs/config: more tests for default-series

Laying the foundation for cross series bootstrapping.

https://code.launchpad.net/~dave-cheney/juju-core/057-environs-config-default-series-tests/+merge/137118

(do not edit description out of merge proposal)

[dfc, 2012-11-30 07:33:48]

Please take a look.

[niemeyer, 2012-11-30 17:19:56]

LGTM, with a minor detail:

https://codereview.appspot.com/6856120/diff/1/environs/config/config_test.go
File environs/config/config_test.go (right):

https://codereview.appspot.com/6856120/diff/1/environs/config/config_test.go#...
environs/config/config_test.go:55: series: version.Current.Series,
The "if" check on line 445 below means this won't do anything useful in this
case, I suspect, as it'll go straight to 452. In practice, all of the entries in
this table that do not have a "default-series" are already verifying that it
defaults to the host series.

[dfc, 2012-12-03 02:08:50]

Please take a look.

[dfc, 2012-12-03 02:10:56]

Please take a look.

[dfc, 2012-12-03 02:20:34]

Please take a look.

[niemeyer, 2012-12-03 21:50:59]

https://codereview.appspot.com/6856120/diff/8004/environs/config/config_test.go
File environs/config/config_test.go (right):

https://codereview.appspot.com/6856120/diff/8004/environs/config/config_test....
environs/config/config_test.go:447: if test.series != "" {
This can be de-dented:

} else if test.series {
    ...
} else {
    ...
}

But in fact, none of the current tests above exercise test.series, since all of
the tests are either ensuring version.Current.Series, which is the default, or
they contain "default-series".

Do we need test.series for some upcoming test? If so, that sounds fine, but then
I suggest dropping the current uses in the table above to make things more
clear, since the assertions here will be the same.

[dfc, 2012-12-03 21:56:59]

I'm still struggling with testing CL 6851081. My hope was that by adding tests
here it would reduce the scope that needed to be tested in environs/ec2

[niemeyer, 2012-12-03 22:04:09]

I've sent a reply to your comment on the list, with a potential suggestion. Not
quite sure if it'll be helpful. Please let me know either way.