Issue 6855101: environs/ec2: make tests pass on quantal

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6855101: environs/ec2: make tests pass on quantal (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dfc

Modified:
9 years, 6 months ago

Reviewers:
mp+136297, niemeyer

Visibility:
Public.

Description

environs/ec2: make tests pass on quantal Backport of the less controversial parts of ~dave-cheney/juju-core/050-environs-respect-default-series-II. https://code.launchpad.net/~dave-cheney/juju-core/056-environs-ec2-tests-pass-on-quantal/+merge/136297 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: make tests pass on quantal #

Patch Set 3 : environs/ec2: make tests pass on quantal #

Patch Set 4 : environs/ec2: make tests pass on quantal #

Patch Set 5 : environs/ec2: make tests pass on quantal #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -30 lines)			Patch
A	[revision details]	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cert/cert.go	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	environs/ec2/testdata/query/quantal/server/daily.current.txt	View		1 chunk	+35 lines, -29 lines	0 comments	Download
A	environs/ec2/testdata/query/quantal/server/released.current.txt	View		1 chunk	+39 lines, -0 lines	0 comments	Download
M	environs/tools.go	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dfc

Ping. This should be straight forward. This proposal adds only the fixtures to make the ...

11 years, 4 months ago (2012-11-28 05:50:38 UTC) #3

niemeyer

LGTM, please feel free to integrate this without another review as it's straightforward and logic-less.

11 years, 4 months ago (2012-11-28 13:03:31 UTC) #4

dfc

11 years, 4 months ago (2012-11-28 21:16:46 UTC) #5

*** Submitted:

environs/ec2: make tests pass on quantal

Backport of the less controversial parts of
~dave-cheney/juju-core/050-environs-respect-default-series-II.

R=niemeyer
CC=
https://codereview.appspot.com/6855101

Expand All Messages | Collapse All Messages