Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(574)

Issue 6855100: code review 6855100: cmd/5g, cmd/8g: fix internal error on 64-bit indices st... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by remyoudompheng
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

cmd/5g, cmd/8g: fix internal error on 64-bit indices statically bounded Fixes issue 4448.

Patch Set 1 #

Patch Set 2 : diff -r 8f9a26de2b20 https://code.google.com/p/go #

Patch Set 3 : diff -r 8f9a26de2b20 https://code.google.com/p/go #

Patch Set 4 : diff -r b8c822e083cf https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -13 lines) Patch
M src/cmd/5g/cgen.c View 1 6 chunks +7 lines, -5 lines 0 comments Download
M src/cmd/5g/gg.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/5g/gsubr.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8g/cgen.c View 1 4 chunks +8 lines, -6 lines 0 comments Download
A test/fixedbugs/issue4448.go View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2012-11-26 23:28:48 UTC) #1
rsc
LGTM
11 years, 4 months ago (2012-11-27 16:42:06 UTC) #2
remyoudompheng
11 years, 4 months ago (2012-11-27 20:38:11 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=9049dd504139 ***

cmd/5g, cmd/8g: fix internal error on 64-bit indices statically bounded

Fixes issue 4448.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6855100
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b