Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 6855053: code review 6855053: test: add test for floating point rounding of constants (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by iant
Modified:
9 years, 7 months ago
Reviewers:
CC:
golang-dev, remyoudompheng, rsc
Visibility:
Public.

Description

test: add test for floating point rounding of constants Failed with gccgo.

Patch Set 1 #

Patch Set 2 : diff -r 9764a39320d8 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 3 : diff -r b5f58df8efce https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
A test/fixedbugs/bug470.go View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 7 months ago (2012-11-16 06:51:19 UTC) #1
remyoudompheng
Is this specified anywhere? http://golang.org/ref/spec#Constant_expressions says: "A compiler may use rounding while computing untyped floating-point ...
9 years, 7 months ago (2012-11-16 07:01:32 UTC) #2
remyoudompheng
The spec says: "That said, every implementation must: Represent floating-point constants, including the parts of ...
9 years, 7 months ago (2012-11-16 07:08:21 UTC) #3
iant
On 2012/11/16 07:01:32, remyoudompheng wrote: > Is this specified anywhere? > > http://golang.org/ref/spec#Constant_expressions says: > ...
9 years, 7 months ago (2012-11-16 14:17:28 UTC) #4
iant
On 2012/11/16 07:08:21, remyoudompheng wrote: > The spec says: "That said, every implementation must: Represent ...
9 years, 7 months ago (2012-11-16 14:22:20 UTC) #5
iant
http://code.google.com/p/go/issues/detail?id=4398
9 years, 7 months ago (2012-11-16 14:38:37 UTC) #6
remyoudompheng
On 2012/11/16 14:22:20, iant wrote: > But I just now spotted another use of "typed ...
9 years, 7 months ago (2012-11-16 15:06:06 UTC) #7
iant
On 2012/11/16 15:06:06, remyoudompheng wrote: > On 2012/11/16 14:22:20, iant wrote: > > But I ...
9 years, 7 months ago (2012-11-16 15:19:55 UTC) #8
rsc
LGTM The part about "is 0.01" is not precisely correct. The numbers below are the ...
9 years, 7 months ago (2012-11-26 15:37:05 UTC) #9
iant
9 years, 7 months ago (2012-11-26 16:31:22 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=b26a08dc81f0 ***

test: add test for floating point rounding of constants

Failed with gccgo.

R=golang-dev, remyoudompheng, rsc
CC=golang-dev
http://codereview.appspot.com/6855053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b