Issue 6854103: code review 6854103: runtime/race: add test case for issue 4453

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6854103: code review 6854103: runtime/race: add test case for issue 4453 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dvyukov

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

runtime/race: add test case for issue 4453

Patch Set 2 : diff -r e03ad98f9165 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r e03ad98f9165 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r e03ad98f9165 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r e03ad98f9165 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r a522fb590152 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r efc46b2230aa https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	src/pkg/runtime/race/testdata/mop_test.go	View	1 2 3 4	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 4 months ago (2012-11-27 14:56:47 UTC) #1

bradfitz

LGTM https://codereview.appspot.com/6854103/diff/2002/src/pkg/runtime/race/testdata/mop_test.go File src/pkg/runtime/race/testdata/mop_test.go (right): https://codereview.appspot.com/6854103/diff/2002/src/pkg/runtime/race/testdata/mop_test.go#newcode1242 src/pkg/runtime/race/testdata/mop_test.go:1242: // http://code.google.com/p/go/issues/detail?id=4453 Shorter: // http://golang.org/issue/4453

11 years, 4 months ago (2012-11-27 17:49:05 UTC) #2

dvyukov

https://codereview.appspot.com/6854103/diff/2002/src/pkg/runtime/race/testdata/mop_test.go File src/pkg/runtime/race/testdata/mop_test.go (right): https://codereview.appspot.com/6854103/diff/2002/src/pkg/runtime/race/testdata/mop_test.go#newcode1242 src/pkg/runtime/race/testdata/mop_test.go:1242: // http://code.google.com/p/go/issues/detail?id=4453 On 2012/11/27 17:49:05, bradfitz wrote: > Shorter: ...

11 years, 4 months ago (2012-11-27 17:57:40 UTC) #3

dvyukov

11 years, 4 months ago (2012-11-27 17:59:13 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=02ea89fefd91 ***

runtime/race: add test case for issue 4453

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6854103

Expand All Messages | Collapse All Messages