Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(330)

Issue 6854102: code review 6854102: net: fix intermittent TestAddFDReturnsError failure (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by dfc
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

net: fix intermittent TestAddFDReturnsError failure A fix similar to CL 6859043 was effective in resolving the intermittent failure. Fixes issue 4423.

Patch Set 1 #

Patch Set 2 : diff -r 34e54cf71fed https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 34e54cf71fed https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 34e54cf71fed https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 589646797508 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/pkg/net/fd_unix_test.go View 1 3 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 3
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 4 months ago (2012-11-27 12:54:19 UTC) #1
rsc
LGTM
11 years, 4 months ago (2012-11-27 15:28:06 UTC) #2
dfc
11 years, 4 months ago (2012-11-27 23:25:09 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=2788bd8b6b7f ***

net: fix intermittent TestAddFDReturnsError failure

A fix similar to CL 6859043 was effective in resolving the intermittent failure.

Fixes issue 4423.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6854102
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b