Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(619)

Issue 6854092: $acmeshell: supply filename in $0

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by marius.eriksen
Modified:
1 year, 4 months ago
Reviewers:
rsc
CC:
rsc, codebot
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : $samfile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M man/man1/acme.1 View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/acme/exec.c View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7
marius.eriksen
1 year, 4 months ago #1
marius.eriksen
After using $acmeshell for a while, I was really beginning to miss $%, which isn't ...
1 year, 4 months ago #2
rsc
Making it argv[0] does not make sense to me. The file is not what is ...
1 year, 4 months ago #3
marius.eriksen
1 year, 4 months ago #4
rsc
LGTM
1 year, 4 months ago #5
marius.eriksen
I can live with that. It also has the major advantage of being passed through ...
1 year, 4 months ago #6
rsc
1 year, 4 months ago #7
*** Submitted as http://code.google.com/p/plan9port/source/detail?r=27ec22f7be57
***

acme: set $samfile (same as $%) during execution

R=rsc
CC=plan9port.codebot
http://codereview.appspot.com/6854092

Committer: Russ Cox <rsc@swtch.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5