Issue 6852105: code review 6852105: undo CL 6855110 / 869253ef7009

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6852105: code review 6852105: undo CL 6855110 / 869253ef7009 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dave

Modified:
11 years, 4 months ago

Reviewers:
dvyukov

CC:
rsc, mikio, minux1, golang-dev

Visibility:
Public.

Description

undo CL 6855110 / 869253ef7009 64bit atomics are broken on 32bit systems. This is issue 599. linux/arm builders all broke with this change, I am concerned that the other 32bit builders are silently impacted. ««« original CL description net: fix data races on deadline vars Fixes issue 4434. R=mikioh.mikioh, bradfitz, dvyukov, alex.brainman CC=golang-dev https://codereview.appspot.com/6855110 »»»

Patch Set 1 #

Patch Set 2 : diff -r 869253ef7009 https://code.google.com/p/go #

Patch Set 3 : diff -r 869253ef7009 https://code.google.com/p/go #

Patch Set 4 : diff -r 869253ef7009 https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -167 lines)			Patch
R	src/pkg/net/fd_posix_test.go	View	1	1 chunk	+0 lines, -57 lines	0 comments	Download
M	src/pkg/net/fd_unix.go	View	1	13 chunks	+53 lines, -61 lines	0 comments	Download
M	src/pkg/net/fd_windows.go	View	1	6 chunks	+10 lines, -38 lines	0 comments	Download
M	src/pkg/net/sendfile_freebsd.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/sendfile_linux.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/net/sock_posix.go	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/pkg/net/sockopt_posix.go	View	1	1 chunk	+14 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello rsc@golang.org, mikioh.mikioh@gmail.com, dvyukov@google.com, minux.ma@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to ...

11 years, 4 months ago (2012-11-30 08:56:12 UTC) #1

dave_cheney.net

*** Submitted as https://code.google.com/p/go/source/detail?r=697f36fec52c *** undo CL 6855110 / 869253ef7009 64bit atomics are broken on ...

11 years, 4 months ago (2012-11-30 09:02:49 UTC) #3

dvyukov

11 years, 4 months ago (2012-11-30 09:26:16 UTC) #4

Message was sent while issue was closed.

On 2012/11/30 09:02:49, dfc wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=697f36fec52c ***
> 
> undo CL 6855110 / 869253ef7009
> 
> 64bit atomics are broken on 32bit systems. This is issue 599.
> 
> linux/arm builders all broke with this change, I am concerned that the other
> 32bit builders are silently impacted.
> 
> ««« original CL description
> net: fix data races on deadline vars
> 
> Fixes issue 4434.
> 
> R=mikioh.mikioh, bradfitz, dvyukov, alex.brainman
> CC=golang-dev
> https://codereview.appspot.com/6855110
> »»»
> 
> R=rsc, mikioh.mikioh, dvyukov, minux.ma
> CC=golang-dev
> https://codereview.appspot.com/6852105

The issue 599 causes non-atomicity of 64-bit atomics on 386. It leads to crashes
only if you you heavily stress atomicity. I do not think that it should causes
instant crashes in this case. Moreover, ARM seems to be using STREX/LDREX for
64-bit atomic loads/stores, so most likely it does not even have the problem.
Perhaps ARM builders are affected by something else.

Expand All Messages | Collapse All Messages