Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3955)

Issue 6852059: Proper handling of incoming mail without charset and encoding. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Andi
Modified:
1 year, 5 months ago
Reviewers:
GvR, M-A
CC:
codereview-discuss_googlegroups.com
Visibility:
Public.

Description

We've got a lot of UnicodeDecodeErrors in the logs caused by incoming mails
where charset and encoding is None. That there so much errors is because
Appengine tries to re-post the mail to the handler as it currently fails with an
500 error, so most of the logged errors are duplicates.

The messages that make troubles have no encoding and charset but contain
non-ASCII chars. The conversion to db.Text() when storing the message fails.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M codereview/views.py View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/test_incomingmail.py View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Andi
1 year, 5 months ago #1
M-A
Know which emails clients do that? lgtm
1 year, 5 months ago #2
Andi
1 year, 5 months ago #3
I've logged only one message and it had only a minimal set of headers. Out
of my mind just From, To and Subject.

Andi

On Friday, November 16, 2012, wrote:

> Know which emails clients do that?
>
> lgtm
>
>
https://codereview.appspot.**com/6852059/<https://codereview.appspot.com/6852...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5