Issue 6851071: code review 6851071: go.talks/present: fix static file path calculation and ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6851071: code review 6851071: go.talks/present: fix static file path calculation and ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by minux1

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

go.talks/present: fix static file path calculation and skip the "pkg" directory also chmod -x two other files.

Patch Set 1 #

Patch Set 2 : diff -r 232d341de375 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r 3a315071e5e9 https://code.google.com/p/go.talks #

Patch Set 4 : diff -r 3a315071e5e9 https://code.google.com/p/go.talks #

Patch Set 5 : diff -r 3a315071e5e9 https://code.google.com/p/go.talks #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
M	present/appengine.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	present/dir.go	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	present/main.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	present/static/styles.css	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	present/templates/slides.tmpl	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks

11 years, 5 months ago (2012-11-23 13:04:16 UTC) #1

minux1

11 years, 4 months ago (2012-11-30 16:34:41 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=ccdbe016704c&repo=talks ***

go.talks/present: fix static file path calculation and skip the "pkg" directory
also chmod -x two other files.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/6851071

Expand All Messages | Collapse All Messages