Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3448)

Issue 6850105: state: common UnitsWatcher

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by fwereade
Modified:
11 years, 4 months ago
Reviewers:
mp+136197
Visibility:
Public.

Description

state: common UnitsWatcher This allows Machine.WatchPrincipalUnits and Unit.WatchSubordinateUnits to share a common watcher type, paving the way for a common Installer task to run in the respective agents. Note: The existing MachinePrincipalUnitsWatcher is too deeply embedded for its extraction to be practical within the scope of this CL. A followup will replace Machiner with Installer, and make redundant that client; further followups will attempt to address the Firewaller/MachineUnitsWatcher. https://code.launchpad.net/~fwereade/juju-core/common-units-watcher/+merge/136197 Requires: https://code.launchpad.net/~fwereade/juju-core/machine-string-ids/+merge/135423 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : state: common UnitsWatcher #

Total comments: 5

Patch Set 3 : state: common UnitsWatcher #

Patch Set 4 : state: common UnitsWatcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+499 lines, -0 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M state/export_test.go View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M state/machine_test.go View 1 chunk +231 lines, -0 lines 0 comments Download
M state/unit_test.go View 1 2 3 2 chunks +72 lines, -0 lines 0 comments Download
M state/watcher.go View 1 2 1 chunk +178 lines, -0 lines 0 comments Download

Messages

Total messages: 7
fwereade
Please take a look.
11 years, 4 months ago (2012-11-26 15:05:12 UTC) #1
fwereade
Please take a look.
11 years, 4 months ago (2012-11-26 17:05:01 UTC) #2
niemeyer
Very good logic, thanks. Just one minor issue there. https://codereview.appspot.com/6850105/diff/3001/state/export_test.go File state/export_test.go (right): https://codereview.appspot.com/6850105/diff/3001/state/export_test.go#newcode23 state/export_test.go:23: ...
11 years, 4 months ago (2012-11-27 23:40:05 UTC) #3
rog
LGTM https://codereview.appspot.com/6850105/diff/1/state/watcher.go File state/watcher.go (right): https://codereview.appspot.com/6850105/diff/1/state/watcher.go#newcode1053 state/watcher.go:1053: if known && gone { surely this is ...
11 years, 4 months ago (2012-11-28 09:03:15 UTC) #4
fwereade
Please take a look. https://codereview.appspot.com/6850105/diff/1/state/watcher.go File state/watcher.go (right): https://codereview.appspot.com/6850105/diff/1/state/watcher.go#newcode1053 state/watcher.go:1053: if known && gone { ...
11 years, 4 months ago (2012-11-28 09:44:54 UTC) #5
niemeyer
LGTM
11 years, 4 months ago (2012-11-28 11:51:52 UTC) #6
fwereade
11 years, 4 months ago (2012-11-28 15:52:19 UTC) #7
*** Submitted:

state: common UnitsWatcher

This allows Machine.WatchPrincipalUnits and Unit.WatchSubordinateUnits to
share a common watcher type, paving the way for a common Installer task to
run in the respective agents.

Note: The existing MachinePrincipalUnitsWatcher is too deeply embedded for
its extraction to be practical within the scope of this CL. A followup will
replace Machiner with Installer, and make redundant that client; further
followups will attempt to address the Firewaller/MachineUnitsWatcher.

R=niemeyer, rog
CC=
https://codereview.appspot.com/6850105
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b