Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1150)

Issue 6850097: code review 6850097: cmd/gc: fix invalid indirect error at statement level (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by minux1
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, remyoudompheng, DMorsing, rsc
Visibility:
Public.

Description

cmd/gc: fix invalid indirect error at statement level Fixes issue 4429.

Patch Set 1 #

Patch Set 2 : diff -r 107e46216b58 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 107e46216b58 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r 3ec963539561 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M src/cmd/gc/typecheck.c View 1 1 chunk +1 line, -1 line 0 comments Download
A test/fixedbugs/issue4429.go View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 4 months ago (2012-11-24 09:37:53 UTC) #1
remyoudompheng
http://codereview.appspot.com/6850097/diff/7001/src/cmd/gc/typecheck.c File src/cmd/gc/typecheck.c (right): http://codereview.appspot.com/6850097/diff/7001/src/cmd/gc/typecheck.c#newcode485 src/cmd/gc/typecheck.c:485: if((top & (Erv | Etop)) && !isptr[t->etype]) { why ...
11 years, 4 months ago (2012-11-24 12:25:03 UTC) #2
minux1
https://codereview.appspot.com/6850097/diff/7001/src/cmd/gc/typecheck.c File src/cmd/gc/typecheck.c (right): https://codereview.appspot.com/6850097/diff/7001/src/cmd/gc/typecheck.c#newcode485 src/cmd/gc/typecheck.c:485: if((top & (Erv | Etop)) && !isptr[t->etype]) { On ...
11 years, 4 months ago (2012-11-24 16:57:20 UTC) #3
remyoudompheng
LGTM
11 years, 4 months ago (2012-11-25 08:16:41 UTC) #4
DMorsing
This looks more like an invalid typecast than an invalid indirect to me. I don't ...
11 years, 4 months ago (2012-11-25 08:56:17 UTC) #5
minux1
On Sunday, November 25, 2012, wrote: > This looks more like an invalid typecast than ...
11 years, 4 months ago (2012-11-25 09:08:28 UTC) #6
DMorsing
Nevermind, I was mistaken. I still have this nagging feeling that this error will happen ...
11 years, 4 months ago (2012-11-25 10:04:35 UTC) #7
rsc
LGTM
11 years, 4 months ago (2012-11-26 17:25:38 UTC) #8
minux1
11 years, 4 months ago (2012-11-26 17:47:05 UTC) #9
*** Submitted as http://code.google.com/p/go/source/detail?r=026b89723112 ***

cmd/gc: fix invalid indirect error at statement level
Fixes issue 4429.

R=golang-dev, remyoudompheng, daniel.morsing, rsc
CC=golang-dev
http://codereview.appspot.com/6850097
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b