code review 6847129: net: undo part of CL6ec24fe2e501.

net: undo part of CL6845119 (revision 6ec24fe2e501).

The removal of fd.Close might leave a netFD on an
invalid Handle with a non-nil finalizer on Windows
systems.

[remyoudompheng, 2012-12-01 12:49:13]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2012-12-01 13:20:34]

LGTM

[brainman, 2012-12-01 23:41:01]

I do not know what to do.

I do not follow net changes closely. There are too many.

I also looked in the history, and it does not help.

scok_posix.go is shared by many os. Therefore, whatever goes in there should be
sensible for every os, not just for some. Is Close needed in here for unix? If
not, perhaps, windows code need to be rearranged accordingly.

Feel free to do whatever you think is right - submit or drop this CL. Do not
worry about braking windows build. I will investigate this anyway when I have
more time.

Alex

[brainman, 2012-12-03 01:27:47]

I cannot reproduce failures we are seeing on windows/386 builder. Perhaps, it is
because of finaliser. I would like to propose
https://codereview.appspot.com/6873046/ to fix the mess. It is not clear to me
the reasons why code is structured the way it is structured, but at least my
change makes windows code similar to unix.

Please, review. Thank you.

Alex

[remyoudompheng, 2012-12-06 07:05:08]

*** Abandoned ***