Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1191)

Issue 6847101: code review 6847101: net/http/httptest: protect against port reuse (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by bradfitz
Modified:
10 years ago
Reviewers:
CC:
golang-dev, minux1
Visibility:
Public.

Description

net/http/httptest: protect against port reuse Should make BSDs more reliable. (they seem to reuse ports quicker than Linux) Tested by hand with local modifications to force reuse on Linux. (net/http tests failed before, pass now) Details in the issue. Fixes issue 4436

Patch Set 1 #

Patch Set 2 : diff -r cda840e2befc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r cda840e2befc https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r cda840e2befc https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/pkg/net/http/httptest/server.go View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years ago (2012-11-25 19:57:51 UTC) #1
minux1
https://codereview.appspot.com/6847101/diff/5001/src/pkg/net/http/httptest/server.go File src/pkg/net/http/httptest/server.go (right): https://codereview.appspot.com/6847101/diff/5001/src/pkg/net/http/httptest/server.go#newcode159 src/pkg/net/http/httptest/server.go:159: if t, ok := http.DefaultTransport.(*http.Transport); ok { if we ...
10 years ago (2012-11-25 20:06:10 UTC) #2
bradfitz
People who make their own Transports are fine: they'll have their own connection cache never ...
10 years ago (2012-11-25 20:12:43 UTC) #3
minux1
LGTM.
10 years ago (2012-11-25 20:27:06 UTC) #4
bradfitz
10 years ago (2012-11-25 23:23:25 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=cd3ad8805953 ***

net/http/httptest: protect against port reuse

Should make BSDs more reliable. (they seem to reuse ports
quicker than Linux)

Tested by hand with local modifications to force reuse on
Linux. (net/http tests failed before, pass now) Details in the
issue.

Fixes issue 4436

R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6847101
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b