Issue 6847091: environs: move Bootstrap from juju

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6847091: environs: move Bootstrap from juju

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rog

Modified:
11 years, 5 months ago

Reviewers:
mp+135784

Visibility:
Public.

Description

environs: move Bootstrap from juju It's a mechanical change with no behaviour alterations. As discussed online, this is a more sensible place for it. https://code.launchpad.net/~rogpeppe/juju-core/161-move-bootstrap/+merge/135784 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: move Bootstrap from juju #

Patch Set 3 : environs: move Bootstrap from juju #

Total comments: 1

Patch Set 4 : environs: move Bootstrap from juju #

Patch Set 5 : environs: move Bootstrap from juju #

Patch Set 6 : environs: move Bootstrap from juju #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -31 lines)			Patch
A	[revision details]	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/builddb/main.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	environs/bootstrap.go	View	1 2 3 4 5	3 chunks	+3 lines, -4 lines	0 comments	Download
M	environs/bootstrap_test.go	View	1 2 3 4 5	7 chunks	+7 lines, -8 lines	0 comments	Download
M	environs/ec2/local_test.go	View	1 2 3 4 5	2 chunks	+1 line, -2 lines	0 comments	Download
M	environs/jujutest/livetests.go	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	environs/jujutest/tests.go	View		4 chunks	+6 lines, -7 lines	0 comments	Download
M	juju/conn_test.go	View	1 2 3 4 5	6 chunks	+6 lines, -6 lines	0 comments	Download
M	juju/testing/conn.go	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Makes sense to me, give bootstrap is done entirely from the client. https://codereview.appspot.com/6847091/diff/4001/environs/bootstrap.go File environs/bootstrap.go ...

11 years, 5 months ago (2012-11-23 17:25:34 UTC) #2

rog

11 years, 5 months ago (2012-11-26 16:26:28 UTC) #5

*** Submitted:

environs: move Bootstrap from juju

It's a mechanical change with no behaviour alterations.
As discussed online, this is a more sensible place for it.

R=gz, niemeyer
CC=
https://codereview.appspot.com/6847091

Expand All Messages | Collapse All Messages