Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(48)

Issue 6847080: quickstart-PR review

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by holger krekel
Modified:
1 year, 5 months ago
Reviewers:
Visibility:
Public.

Description

quickstart-PR review

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -1 line) Patch
M setup.py View 1 chunk +1 line, -1 line 1 comment Download
A tests/test_quickstart.py View 1 chunk +98 lines, -0 lines 0 comments Download
M tox/__init__.py View 1 chunk +1 line, -0 lines 1 comment Download
A tox/_quickstart.py View 1 chunk +219 lines, -0 lines 2 comments Download

Messages

Total messages: 1
holger krekel
1 year, 5 months ago #1
http://codereview.appspot.com/6847080/diff/1/setup.py
File setup.py (left):

http://codereview.appspot.com/6847080/diff/1/setup.py#oldcode59
setup.py:59: # we use a public tox version to test, see tox.ini's testenv
this can directly reference tox._quickstart:main so that tox/__init__ doesn't
need to include it.

http://codereview.appspot.com/6847080/diff/1/tox/__init__.py
File tox/__init__.py (right):

http://codereview.appspot.com/6847080/diff/1/tox/__init__.py#newcode24
tox/__init__.py:24: from tox._quickstart import main as quickstart
this import is not needed and slows down the general tox importing

http://codereview.appspot.com/6847080/diff/1/tox/_quickstart.py
File tox/_quickstart.py (right):

http://codereview.appspot.com/6847080/diff/1/tox/_quickstart.py#newcode162
tox/_quickstart.py:162: - python setup.py test
this desparately needs a py.test choice! :)

http://codereview.appspot.com/6847080/diff/1/tox/_quickstart.py#newcode172
tox/_quickstart.py:172: 
let's default the dependencies to nose for "nosetests", "pytest" for "py.test"
and "twisted" for "trial".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5