Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(133)

Issue 6846045: code review 6846045: regexp: add simple package-level example (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by adg
Modified:
9 years, 6 months ago
Reviewers:
CC:
golang-dev, r
Visibility:
Public.

Description

regexp: add simple package-level example Update issue 4125

Patch Set 1 #

Total comments: 4

Patch Set 2 : diff -r badc904a3473 https://code.google.com/p/go #

Patch Set 3 : diff -r d9896259d8e5 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
A src/pkg/regexp/example_test.go View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 6
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 6 months ago (2012-11-13 11:53:05 UTC) #1
r
http://codereview.appspot.com/6846045/diff/1/src/pkg/regexp/example_test.go File src/pkg/regexp/example_test.go (right): http://codereview.appspot.com/6846045/diff/1/src/pkg/regexp/example_test.go#newcode9 src/pkg/regexp/example_test.go:9: // Compile the expression once, usually at init time. ...
9 years, 6 months ago (2012-11-13 15:26:03 UTC) #2
adg
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 6 months ago (2012-11-13 15:54:46 UTC) #3
adg
https://codereview.appspot.com/6846045/diff/1/src/pkg/regexp/example_test.go File src/pkg/regexp/example_test.go (right): https://codereview.appspot.com/6846045/diff/1/src/pkg/regexp/example_test.go#newcode9 src/pkg/regexp/example_test.go:9: // Compile the expression once, usually at init time. ...
9 years, 6 months ago (2012-11-13 15:54:48 UTC) #4
r
LGTM
9 years, 6 months ago (2012-11-13 17:15:43 UTC) #5
adg
9 years, 6 months ago (2012-11-14 09:43:27 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=cbb5a28097e9 ***

regexp: add simple package-level example

Update issue 4125

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6846045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b