Issue 6842101: net: add test for timeouts on consecutive reads

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6842101: net: add test for timeouts on consecutive reads

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by jsing

Modified:
11 years, 5 months ago

Reviewers:
dave

Visibility:
Public.

Description

net: add test for timeouts on consecutive reads Add a currently failing test for timeouts on consecutive reads. Deadlines should apply to all future I/O, not just the Read that follows SetReadDeadline.

Patch Set 1 #

Patch Set 2 : diff -r 03a6b8c9c396 https://go.googlecode.com/hg/ #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -1 line)			Patch
	M	src/pkg/net/timeout_test.go	View	1	2 chunks	+48 lines, -1 line	2 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

dave_cheney.net

11 years, 5 months ago (2012-11-27 21:25:05 UTC) #1

This looks goog, please hg mail it for wider review.

https://codereview.appspot.com/6842101/diff/2001/src/pkg/net/timeout_test.go
File src/pkg/net/timeout_test.go (right):

https://codereview.appspot.com/6842101/diff/2001/src/pkg/net/timeout_test.go#...
src/pkg/net/timeout_test.go:560: t.Fatalf("Accept: %v", err)
t.Errorf() ; return

can't use t.Fatal in goroutines, issue 3800.

https://codereview.appspot.com/6842101/diff/2001/src/pkg/net/timeout_test.go#...
src/pkg/net/timeout_test.go:573: defer c.Close()
you may have to do the <- connected trick from CL 6854102

Expand All Messages | Collapse All Messages