Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(821)

Issue 6842078: code review 6842078: bufio: Optimize (*Writer).ReadFrom when the buffer is n... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by chaten
Modified:
8 years, 11 months ago
Reviewers:
golang-dev, dfc, bradfitz
CC:
golang-dev, nigeltao
Visibility:
Public.

Description

bufio: Optimize (*Writer).ReadFrom when the buffer is not empty

Patch Set 1 #

Patch Set 2 : diff -r 1315abc581ed https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1315abc581ed https://code.google.com/p/go/ #

Total comments: 7

Patch Set 4 : diff -r 1315abc581ed https://code.google.com/p/go/ #

Patch Set 5 : diff -r 1315abc581ed https://code.google.com/p/go/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -23 lines) Patch
M src/pkg/bufio/bufio.go View 1 2 3 1 chunk +26 lines, -16 lines 1 comment Download
M src/pkg/bufio/bufio_test.go View 1 2 3 4 3 chunks +57 lines, -7 lines 0 comments Download

Messages

Total messages: 12
chaten
Hello golang-dev@googlegroups.com (cc: nigeltao@golang.org), I'd like you to review this change to https://code.google.com/p/go/
9 years, 6 months ago (2012-11-21 01:42:54 UTC) #1
dfc
your additions to bufio_test do no fail against an unmodified bufio.go. Should they >
9 years, 6 months ago (2012-11-21 01:47:54 UTC) #2
chaten
On 2012/11/21 01:47:54, dfc wrote: > your additions to bufio_test do no fail against an ...
9 years, 6 months ago (2012-11-21 01:59:21 UTC) #3
dfc
> They shouldn't fail on an unmodified version. The modifications make it > so the ...
9 years, 6 months ago (2012-11-21 02:01:09 UTC) #4
bradfitz
https://codereview.appspot.com/6842078/diff/5001/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go (right): https://codereview.appspot.com/6842078/diff/5001/src/pkg/bufio/bufio.go#newcode572 src/pkg/bufio/bufio.go:572: //Want to call Write with the most amt of ...
9 years, 6 months ago (2012-11-21 03:34:43 UTC) #5
chaten
On 2012/11/21 03:34:43, bradfitz wrote: > But why is this comment up here? It should ...
9 years, 5 months ago (2012-11-22 02:06:45 UTC) #6
chaten
On 2012/11/21 02:01:09, dfc wrote: > > They shouldn't fail on an unmodified version. The ...
9 years, 5 months ago (2012-11-22 02:40:56 UTC) #7
dfc
Can you add a test that demonstrates your change prevents the infinite loop in ReadAll ...
9 years, 5 months ago (2012-11-22 03:12:20 UTC) #8
chaten
Hello golang-dev@googlegroups.com, dave@cheney.net, bradfitz@golang.org (cc: golang-dev@googlegroups.com, nigeltao@golang.org), Please take another look.
9 years, 5 months ago (2012-11-22 03:32:39 UTC) #9
chaten
Hello golang-dev@googlegroups.com, dave@cheney.net, bradfitz@golang.org (cc: golang-dev@googlegroups.com, nigeltao@golang.org), Please take another look.
9 years, 5 months ago (2012-11-22 04:00:50 UTC) #10
bradfitz
For a CL about optimizing, you should probably include a BenchmarkFoo function. https://codereview.appspot.com/6842078/diff/7006/src/pkg/bufio/bufio.go File src/pkg/bufio/bufio.go ...
9 years, 5 months ago (2012-11-26 02:58:22 UTC) #11
bradfitz
8 years, 11 months ago (2013-06-04 22:15:08 UTC) #12
R=close

Please reply with a PTAL if there's activity on this again.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b