Issue 68240043: Adding CtExtensions to STH

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68240043: Adding CtExtensions to STH (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by Eran

Modified:
9 years, 11 months ago

Reviewers:
Ben Laurie (Google)

CC:
ctlog-opensource-review_google.com

Visibility:
Public.

More Reviews

Description

Adding CtExtensions to STH. As discussed offline, CtExtensions in the Signed Tree Head will allow the log to include additional data in the future. This is https://code.google.com/p/certificate-transparency/issues/detail?id=28

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding CtSthExtensions #

Patch Set 3 : Documenting extensions. #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	doc/rfc6962-bis.xml	View	1 2	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Ben Laurie (Google)

https://codereview.appspot.com/68240043/diff/1/doc/rfc6962-bis.xml File doc/rfc6962-bis.xml (right): https://codereview.appspot.com/68240043/diff/1/doc/rfc6962-bis.xml#newcode629 doc/rfc6962-bis.xml:629: CtExtensions extensions; I suspect this should have a different ...

10 years, 1 month ago (2014-02-26 15:49:28 UTC) #2

Eran

Addressed comment, PTAL. https://codereview.appspot.com/68240043/diff/1/doc/rfc6962-bis.xml File doc/rfc6962-bis.xml (right): https://codereview.appspot.com/68240043/diff/1/doc/rfc6962-bis.xml#newcode629 doc/rfc6962-bis.xml:629: CtExtensions extensions; On 2014/02/26 15:49:29, Ben ...

10 years, 1 month ago (2014-03-04 14:33:57 UTC) #3

Eran

9 years, 11 months ago (2014-05-02 12:27:44 UTC) #5

Pushed:
https://code.google.com/p/certificate-transparency/source/detail?r=13bfc626f2...

Expand All Messages | Collapse All Messages