Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(651)

Issue 6822107: code review 6822107: go-tour: add note about Go playground's constant clock time (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by minux1
Modified:
11 years, 3 months ago
Reviewers:
CC:
golang-dev, r, adg
Visibility:
Public.

Description

go-tour: add note about Go playground's clock time Also fix a small comment in gotour/local.go

Patch Set 1 #

Patch Set 2 : diff -r 644636efabe0 https://code.google.com/p/go-tour/ #

Total comments: 1

Patch Set 3 : diff -r afef612d0519 https://code.google.com/p/go-tour/ #

Patch Set 4 : diff -r 9f2b64a094e5 https://code.google.com/p/go-tour/ #

Total comments: 1

Patch Set 5 : diff -r 9f2b64a094e5 https://code.google.com/p/go-tour/ #

Patch Set 6 : diff -r 9f2b64a094e5 https://code.google.com/p/go-tour/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M gotour/local.go View 1 1 chunk +1 line, -1 line 0 comments Download
M static/index.html View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go-tour/
11 years, 4 months ago (2012-11-11 17:44:37 UTC) #1
r
LGTM http://codereview.appspot.com/6822107/diff/5001/static/index.html File static/index.html (right): http://codereview.appspot.com/6822107/diff/5001/static/index.html#newcode1080 static/index.html:1080: so don't be surprised if the code gives ...
11 years, 4 months ago (2012-11-11 18:02:56 UTC) #2
minux1
PTAL. On 2012/11/11 18:02:56, r wrote: http://codereview.appspot.com/6822107/diff/5001/static/index.html#newcode1080 > static/index.html:1080: so don't be surprised if the ...
11 years, 4 months ago (2012-11-13 18:30:52 UTC) #3
r
LGTM
11 years, 4 months ago (2012-11-13 18:35:20 UTC) #4
minux1
ping.
11 years, 3 months ago (2012-12-13 14:25:19 UTC) #5
r
LGTM after this mod https://codereview.appspot.com/6822107/diff/15001/static/index.html File static/index.html (right): https://codereview.appspot.com/6822107/diff/15001/static/index.html#newcode1085 static/index.html:1085: Note: Time in the Go ...
11 years, 3 months ago (2012-12-13 17:24:26 UTC) #6
minux1
PTAL. On 2012/12/13 17:24:26, r wrote: > https://codereview.appspot.com/6822107/diff/15001/static/index.html#newcode1085 > static/index.html:1085: Note: Time in the Go ...
11 years, 3 months ago (2012-12-13 17:40:51 UTC) #7
r
LGTM
11 years, 3 months ago (2012-12-13 21:31:26 UTC) #8
adg
LGTM
11 years, 3 months ago (2012-12-13 22:00:51 UTC) #9
minux1
11 years, 3 months ago (2012-12-18 13:19:25 UTC) #10
*** Submitted as https://code.google.com/p/go-tour/source/detail?r=35aa8dc3dadc
***

go-tour: add note about Go playground's clock time
        Also fix a small comment in gotour/local.go

R=golang-dev, r, adg
CC=golang-dev
https://codereview.appspot.com/6822107
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b