Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1274)

Issue 6820124: code review 6820124: net: consolidate common socket functions for Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by mikio
Modified:
11 years, 4 months ago
Reviewers:
CC:
ality, golang-dev, dfc, rsc
Visibility:
Public.

Description

net: consolidate common socket functions for Plan 9 This CL extends changeset 13126:fc4a62e14aba to Plan 9.

Patch Set 1 #

Patch Set 2 : diff -r e9a8a01f5d33 https://code.google.com/p/go #

Patch Set 3 : diff -r e9a8a01f5d33 https://code.google.com/p/go #

Total comments: 3

Patch Set 4 : diff -r 90e59cec3396 https://code.google.com/p/go #

Patch Set 5 : diff -r 27bce3a1244d https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -597 lines) Patch
M src/pkg/net/fd_plan9.go View 1 2 chunks +47 lines, -271 lines 0 comments Download
M src/pkg/net/ipsock_plan9.go View 1 2 3 4 4 chunks +19 lines, -183 lines 0 comments Download
M src/pkg/net/net.go View 1 2 chunks +97 lines, -0 lines 0 comments Download
R src/pkg/net/net_posix.go View 1 1 chunk +0 lines, -110 lines 0 comments Download
M src/pkg/net/tcpsock_plan9.go View 1 2 3 4 7 chunks +100 lines, -15 lines 0 comments Download
M src/pkg/net/udpsock_plan9.go View 1 8 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 5
mikio
Hello ality@pbrane.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2012-11-10 04:54:43 UTC) #1
dfc
Thank you for this new proposal, the intention is a lot clearer. How does moving ...
11 years, 4 months ago (2012-11-10 05:58:09 UTC) #2
mikio
On Sat, Nov 10, 2012 at 2:58 PM, <dave@cheney.net> wrote: > How does moving the ...
11 years, 4 months ago (2012-11-10 06:21:16 UTC) #3
rsc
LGTM
11 years, 4 months ago (2012-11-12 20:45:49 UTC) #4
mikio
11 years, 4 months ago (2012-11-13 07:18:46 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=fc4e67d82024 ***

net: consolidate common socket functions for Plan 9

This CL extends changeset 13126:fc4a62e14aba to Plan 9.

R=ality, golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6820124

http://codereview.appspot.com/6820124/diff/1002/src/pkg/net/ipsock_plan9.go
File src/pkg/net/ipsock_plan9.go (right):

http://codereview.appspot.com/6820124/diff/1002/src/pkg/net/ipsock_plan9.go#n...
src/pkg/net/ipsock_plan9.go:143: l := &netFD{}
On 2012/11/10 05:58:09, dfc wrote:
> what about using the literal syntax here ?

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b