Issue 6819081: code review 6819081: net/rpc: give hint to pass a pointer to Register

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6819081: code review 6819081: net/rpc: give hint to pass a pointer to Register (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by minux1

Modified:
11 years, 5 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

net/rpc: give hint to pass a pointer to Register Fixes issue 4325.

Patch Set 2 : diff -r 126c37a9e33c https://code.google.com/p/go/ #

Total comments: 3

Patch Set 3 : diff -r 126c37a9e33c https://code.google.com/p/go/ #

Patch Set 4 : diff -r 126c37a9e33c https://code.google.com/p/go/ #

Patch Set 5 : diff -r 9408d8d87a5a https://code.google.com/p/go/ #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -20 lines)			Patch
	M	src/pkg/net/rpc/server.go	View	1 2 3	2 chunks	+44 lines, -17 lines	0 comments	Download
	M	src/pkg/net/rpc/server_test.go	View	1 2	2 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 5 months ago (2012-11-03 07:38:47 UTC) #1

LGTM http://codereview.appspot.com/6819081/diff/1001/src/pkg/net/rpc/server.go File src/pkg/net/rpc/server.go (right): http://codereview.appspot.com/6819081/diff/1001/src/pkg/net/rpc/server.go#newcode268 src/pkg/net/rpc/server.go:268: // for convenience, we check if a pointer ...

11 years, 5 months ago (2012-11-03 14:27:15 UTC) #2

minux1

11 years, 5 months ago (2012-11-06 21:03:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d2e88aa183da ***

net/rpc: give hint to pass a pointer to Register
Fixes issue 4325.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6819081

Expand All Messages | Collapse All Messages