Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(237)

Issue 6818043: code review 6818043: net: fix a bad cast in dnsmsg.go (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by snaury
Modified:
9 years, 11 months ago
Reviewers:
CC:
golang-dev, dfc, rsc
Visibility:
Public.

Description

net: fix a bad cast in dnsmsg.go Incorrect cast was causing panics when calling String() on dnsMsg with dnsRR_A answers.

Patch Set 1 #

Patch Set 2 : diff -r ab32e21a9e1c https://code.google.com/p/go/ #

Patch Set 3 : diff -r ab32e21a9e1c https://code.google.com/p/go/ #

Patch Set 4 : diff -r ab32e21a9e1c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/net/dnsmsg.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
snaury
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
9 years, 11 months ago (2012-10-28 10:36:42 UTC) #1
snaury
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 11 months ago (2012-10-28 10:37:52 UTC) #2
dfc
On 2012/10/28 10:37:52, snaury wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > Please take another ...
9 years, 11 months ago (2012-10-28 16:40:49 UTC) #3
snaury
On 2012/10/28 16:40:49, dfc wrote: > On 2012/10/28 10:37:52, snaury wrote: > > Hello mailto:golang-dev@googlegroups.com ...
9 years, 11 months ago (2012-10-28 17:46:07 UTC) #4
snaury
On 2012/10/28 16:40:49, dfc wrote: > This code has been wrong for a while, but ...
9 years, 11 months ago (2012-10-28 17:51:39 UTC) #5
rsc
LGTM
9 years, 11 months ago (2012-11-01 16:57:30 UTC) #6
rsc
9 years, 11 months ago (2012-11-01 16:57:48 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=7d691a2266ef ***

net: fix a bad cast in dnsmsg.go

Incorrect cast was causing panics when
calling String() on dnsMsg with dnsRR_A
answers.

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6818043

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b