Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(98)

Issue 6815085: code review 6815085: cmd/gc: check for array bounds overflow in slice expression (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by iant
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, DMorsing, rsc
Visibility:
Public.

Description

cmd/gc: check for array bounds overflow in slice expression The test for this is test/index.go, which is not run by default. That test does not currently pass even after this is applied, due to issue 4348. Fixes issue 4344.

Patch Set 1 #

Total comments: 4

Patch Set 2 : diff -r f781c447da6e https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 3 : diff -r c33545ae0ec0 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r fd3746c787ac https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 9fd632db8de2 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -27 lines) Patch
M src/cmd/gc/typecheck.c View 1 2 3 4 chunks +35 lines, -27 lines 0 comments Download

Messages

Total messages: 7
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 4 months ago (2012-11-05 19:34:32 UTC) #1
DMorsing
Looks good so far. https://codereview.appspot.com/6815085/diff/1/src/cmd/gc/typecheck.c File src/cmd/gc/typecheck.c (right): https://codereview.appspot.com/6815085/diff/1/src/cmd/gc/typecheck.c#newcode917 src/cmd/gc/typecheck.c:917: tp = nil; If the ...
11 years, 4 months ago (2012-11-05 20:58:13 UTC) #2
iant
https://codereview.appspot.com/6815085/diff/1/src/cmd/gc/typecheck.c File src/cmd/gc/typecheck.c (right): https://codereview.appspot.com/6815085/diff/1/src/cmd/gc/typecheck.c#newcode917 src/cmd/gc/typecheck.c:917: tp = nil; On 2012/11/05 20:58:14, DMorsing wrote: > ...
11 years, 4 months ago (2012-11-05 22:38:44 UTC) #3
DMorsing
LGTM https://codereview.appspot.com/6815085/diff/4002/src/cmd/gc/typecheck.c File src/cmd/gc/typecheck.c (right): https://codereview.appspot.com/6815085/diff/4002/src/cmd/gc/typecheck.c#newcode949 src/cmd/gc/typecheck.c:949: yyerror("invalid array index %N (out of bounds for ...
11 years, 4 months ago (2012-11-06 06:02:52 UTC) #4
iant
Sigh. Thanks. https://codereview.appspot.com/6815085/diff/4002/src/cmd/gc/typecheck.c File src/cmd/gc/typecheck.c (right): https://codereview.appspot.com/6815085/diff/4002/src/cmd/gc/typecheck.c#newcode949 src/cmd/gc/typecheck.c:949: yyerror("invalid array index %N (out of bounds ...
11 years, 4 months ago (2012-11-06 14:02:56 UTC) #5
rsc
LGTM
11 years, 4 months ago (2012-11-06 19:09:41 UTC) #6
iant
11 years, 4 months ago (2012-11-06 19:36:04 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=45cd940d4b21 ***

cmd/gc: check for array bounds overflow in slice expression

The test for this is test/index.go, which is not run by
default.  That test does not currently pass even after this is
applied, due to issue 4348.

Fixes issue 4344.

R=golang-dev, daniel.morsing, rsc
CC=golang-dev
http://codereview.appspot.com/6815085
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b