Issue 6815077: Press "d" to mark comment as done

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6815077: Press "d" to mark comment as done (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by danakj

Modified:
11 years, 4 months ago

Reviewers:
Andi Albrecht, Andi

CC:
codereview-list_googlegroups.com, backer_chromium.org, piman

Visibility:
Public.

More Reviews

Description

Press "d" to mark comment as done Adding a new hotkey for replying to comments. Currently, you have to use the mouse in order to reply "Done", or type it out in full. Now, you can press "d" and it does the same as if you clicked "Done". A demo is here: http://danakj-rietveld2.appspot.com/1

Patch Set 1 #

Patch Set 2 : Prevent double post, remove console.logs #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -33 lines)			Patch
M	static/script.js	View	1	4 chunks	+87 lines, -32 lines	2 comments	Download
M	templates/base.html	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	templates/inline_comment.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Andi

LGTM I've already changed the two style nits (see comments) when applying your change as ...

11 years, 5 months ago (2012-11-04 08:13:57 UTC) #2

danakj

11 years, 5 months ago (2012-11-04 18:19:44 UTC) #3

Thanks :)

On Sun, Nov 4, 2012 at 3:13 AM,  <albrecht.andi@gmail.com> wrote:
> LGTM
>
> I've already changed the two style nits (see comments) when applying
> your change as rev f36d73ca8476.
>
> This version is now live too. The JS file is cached, maybe you need to
> reload the page to get the newest version.
>
> Thanks for this patch!
>
>
> https://codereview.appspot.com/6815077/diff/3002/static/script.js
> File static/script.js (right):
>
> https://codereview.appspot.com/6815077/diff/3002/static/script.js#newcode1930
> static/script.js:1930: // Go through this tr and try responding to the
> last comment. The general
> I think that the comment about responding to the last comment belongs to
> the markAsDone function below.
>
> https://codereview.appspot.com/6815077/diff/3002/static/script.js#newcode1991
> static/script.js:1991: M_isElementVisible(this.win,
> hooks[this.hookPos].cells[0]));
> Tabs instead of spaces.
>
> https://codereview.appspot.com/6815077/

Expand All Messages | Collapse All Messages