Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(192)

Issue 6814101: code review 6814101: net: reintegrate protocol specific methods, functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by mikio
Modified:
11 years, 4 months ago
Reviewers:
dfc, rsc, ality
CC:
golang-dev
Visibility:
Public.

Description

net: reintegrate protocol specific methods, functions This CL adds API placeholders to avoid document synchronization between POSIX and Plan 9.

Patch Set 1 : diff -r e3d1b93bfa09 https://code.google.com/p/go #

Patch Set 2 : diff -r e3d1b93bfa09 https://code.google.com/p/go #

Patch Set 3 : diff -r e3d1b93bfa09 https://code.google.com/p/go #

Patch Set 4 : diff -r e3d1b93bfa09 https://code.google.com/p/go #

Patch Set 5 : diff -r b4a8d6b52a2f https://code.google.com/p/go #

Patch Set 6 : diff -r f4796b726694 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+857 lines, -1602 lines) Patch
M src/pkg/net/dial.go View 1 2 3 4 6 chunks +14 lines, -14 lines 0 comments Download
M src/pkg/net/fd_plan9.go View 2 chunks +47 lines, -271 lines 0 comments Download
M src/pkg/net/file.go View 3 chunks +4 lines, -105 lines 0 comments Download
M src/pkg/net/file_plan9.go View 1 chunk +3 lines, -15 lines 0 comments Download
M src/pkg/net/file_unix.go View 3 chunks +3 lines, -15 lines 0 comments Download
M src/pkg/net/file_windows.go View 1 chunk +3 lines, -3 lines 0 comments Download
M src/pkg/net/iprawsock.go View 1 2 3 4 3 chunks +92 lines, -5 lines 0 comments Download
M src/pkg/net/iprawsock_plan9.go View 1 2 3 4 1 chunk +16 lines, -120 lines 0 comments Download
M src/pkg/net/iprawsock_posix.go View 1 2 3 4 5 8 chunks +11 lines, -74 lines 0 comments Download
M src/pkg/net/ipsock_plan9.go View 1 2 3 4 7 chunks +11 lines, -171 lines 0 comments Download
M src/pkg/net/net.go View 2 chunks +97 lines, -0 lines 0 comments Download
R src/pkg/net/net_posix.go View 1 chunk +0 lines, -110 lines 0 comments Download
M src/pkg/net/protoconn_test.go View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M src/pkg/net/tcpsock.go View 1 2 3 4 3 chunks +150 lines, -8 lines 0 comments Download
M src/pkg/net/tcpsock_plan9.go View 1 2 3 4 1 chunk +39 lines, -66 lines 0 comments Download
M src/pkg/net/tcpsock_posix.go View 1 2 3 4 5 chunks +4 lines, -123 lines 0 comments Download
M src/pkg/net/udpsock.go View 1 2 3 4 3 chunks +105 lines, -7 lines 0 comments Download
M src/pkg/net/udpsock_plan9.go View 1 2 3 4 5 4 chunks +32 lines, -96 lines 0 comments Download
M src/pkg/net/udpsock_posix.go View 1 2 3 4 5 9 chunks +11 lines, -82 lines 0 comments Download
M src/pkg/net/unixsock.go View 1 2 3 4 2 chunks +161 lines, -2 lines 0 comments Download
M src/pkg/net/unixsock_plan9.go View 1 2 3 4 1 chunk +19 lines, -166 lines 0 comments Download
M src/pkg/net/unixsock_posix.go View 1 2 3 4 5 9 chunks +32 lines, -148 lines 0 comments Download

Messages

Total messages: 6
mikio
Hello rsc@golang.org, ality@pbrane.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
11 years, 4 months ago (2012-11-08 10:23:19 UTC) #1
mikio
Hello rsc@golang.org, ality@pbrane.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 4 months ago (2012-11-08 12:03:45 UTC) #2
mikio
Hello rsc@golang.org, ality@pbrane.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 4 months ago (2012-11-08 18:21:36 UTC) #3
dfc
On 2012/11/08 18:21:36, mikio wrote: > Hello mailto:rsc@golang.org, mailto:ality@pbrane.org (cc: mailto:golang-dev@googlegroups.com), > > Please take ...
11 years, 4 months ago (2012-11-09 06:33:27 UTC) #4
mikio
On Fri, Nov 9, 2012 at 3:33 PM, <dave@cheney.net> wrote: > I appreciate the sentiment ...
11 years, 4 months ago (2012-11-09 08:40:27 UTC) #5
mikio
11 years, 4 months ago (2012-11-09 11:11:28 UTC) #6
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b