Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(743)

Issue 6814085: ContentEditableField RemoveFormatting#getTableAncestor_ fix (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by hochhaus
Modified:
1 year, 5 months ago
Reviewers:
gboyer
CC:
nnaze
Base URL:
http://closure-library.googlecode.com/svn/trunk/
Visibility:
Public.

Description

ContentEditableField RemoveFormatting#getTableAncestor_ fix

Patch Set 1 #

Total comments: 1

Patch Set 2 : Bound iteration to Field; Add case to unit test #

Total comments: 1

Patch Set 3 : Comment wrapper table in unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M closure/goog/editor/plugins/removeformatting.js View 1 2 chunks +12 lines, -7 lines 0 comments Download
M closure/goog/editor/plugins/removeformatting_test.html View 1 2 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 7
gboyer
Thanks! Is it practical to catch this with a test case in removeformatting_test? https://codereview.appspot.com/6814085/diff/1/closure/goog/editor/plugins/removeformatting.js File ...
1 year, 5 months ago #1
hochhaus
On 2012/11/05 21:41:07, gboyer wrote: > Thanks! Is it practical to catch this with a ...
1 year, 5 months ago #2
gboyer
Looks good to me. Nathan, would you be able to pull it in? https://codereview.appspot.com/6814085/diff/3001/closure/goog/editor/plugins/removeformatting_test.html File ...
1 year, 5 months ago #3
hochhaus
On 2012/11/06 20:06:03, gboyer wrote: > Looks good to me. Nathan, would you be able ...
1 year, 5 months ago #4
nnaze
Will do. Will send you a CL internally. Nathan On Tue, Nov 6, 2012 at ...
1 year, 5 months ago #5
nnaze
Submitted via SVN. Nick will pull it into p4 in when he runs MOE. Nathan ...
1 year, 5 months ago #6
nnaze
1 year, 5 months ago #7
Also Garry I have added you as a committer.

You can patch by checking out with SVN and then running curl
"patch_url" | patch -p0

Nathan

On Thu, Nov 8, 2012 at 11:53 AM, Nathan Naze <nnaze@google.com> wrote:
> Submitted via SVN. Nick will pull it into p4 in when he runs MOE.
>
> Nathan
>
> On Tue, Nov 6, 2012 at 12:54 PM, Nathan Naze <nnaze@google.com> wrote:
>> Will do. Will send you a CL internally.
>>
>> Nathan
>>
>> On Tue, Nov 6, 2012 at 12:06 PM,  <gboyer@google.com> wrote:
>>> Looks good to me. Nathan, would you be able to pull it in?
>>>
>>>
>>>
https://codereview.appspot.com/6814085/diff/3001/closure/goog/editor/plugins/...
>>> File closure/goog/editor/plugins/removeformatting_test.html (right):
>>>
>>>
https://codereview.appspot.com/6814085/diff/3001/closure/goog/editor/plugins/...
>>> closure/goog/editor/plugins/removeformatting_test.html:35: <table>
>>> Add a comment here explaining that the table wrapping is used in a later
>>> test to ensure that it's ignored. Otherwise it looks a bit random :-)
>>>
>>> https://codereview.appspot.com/6814085/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5