Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(632)

Issue 6814060: code review 6814060: crypto: add short hash benchmarks

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by Eric Roshan Eisner
Modified:
11 years, 4 months ago
Reviewers:
CC:
golang-dev, agl1
Visibility:
Public.

Description

crypto: use better hash benchmarks Labels the existing benchmark as stream, and add benchmarks that compute the checksum.

Patch Set 1 #

Patch Set 2 : diff -r 855e36807dae https://go.googlecode.com/hg #

Patch Set 3 : diff -r 855e36807dae https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 855e36807dae https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -32 lines) Patch
M src/pkg/crypto/md5/md5_test.go View 1 2 3 1 chunk +19 lines, -8 lines 0 comments Download
M src/pkg/crypto/sha1/sha1_test.go View 1 2 3 1 chunk +19 lines, -8 lines 0 comments Download
M src/pkg/crypto/sha256/sha256_test.go View 1 2 3 1 chunk +19 lines, -8 lines 0 comments Download
M src/pkg/crypto/sha512/sha512_test.go View 1 2 3 1 chunk +19 lines, -8 lines 0 comments Download

Messages

Total messages: 7
Eric Roshan Eisner
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg
11 years, 5 months ago (2012-10-31 18:30:27 UTC) #1
agl1
https://codereview.appspot.com/6814060/diff/5001/src/pkg/crypto/md5/md5_test.go File src/pkg/crypto/md5/md5_test.go (right): https://codereview.appspot.com/6814060/diff/5001/src/pkg/crypto/md5/md5_test.go#newcode107 src/pkg/crypto/md5/md5_test.go:107: func BenchmarkShortHash(b *testing.B) { Can you call this BenchmarkHash8Bytes ...
11 years, 5 months ago (2012-10-31 19:32:29 UTC) #2
Eric Roshan Eisner
On 2012/10/31 19:32:29, agl1 wrote: > https://codereview.appspot.com/6814060/diff/5001/src/pkg/crypto/md5/md5_test.go > File src/pkg/crypto/md5/md5_test.go (right): > > https://codereview.appspot.com/6814060/diff/5001/src/pkg/crypto/md5/md5_test.go#newcode107 > ...
11 years, 5 months ago (2012-10-31 19:51:46 UTC) #3
agl1
On Wed, Oct 31, 2012 at 3:51 PM, <eric.d.eisner@gmail.com> wrote: > That makes the name ...
11 years, 5 months ago (2012-10-31 19:54:48 UTC) #4
Eric Roshan Eisner
On 2012/10/31 19:54:48, agl1 wrote: > On Wed, Oct 31, 2012 at 3:51 PM, <mailto:eric.d.eisner@gmail.com> ...
11 years, 5 months ago (2012-10-31 21:12:12 UTC) #5
agl1
Changed it around a bit. Will submit in a sec.
11 years, 4 months ago (2012-11-01 18:19:48 UTC) #6
agl1
11 years, 4 months ago (2012-11-01 20:21:32 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=1d9ea73cf6c1 ***

crypto: use better hash benchmarks

Labels the existing benchmark as stream, and add benchmarks that
compute the checksum.

R=golang-dev, agl
CC=golang-dev
http://codereview.appspot.com/6814060

Committer: Adam Langley <agl@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b