Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(487)

Issue 6810095: code review 6810095: runtime/race: more precise handling of finalizers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by dvyukov
Modified:
9 years, 10 months ago
Reviewers:
CC:
golang-dev, minux1, rsc
Visibility:
Public.

Description

runtime/race: more precise handling of finalizers Currently race detector runtime just disables race detection in the finalizer goroutine. It has false positives when a finalizer writes to shared memory -- the race with finalizer is reported in a normal goroutine that accesses the same memory. After this change I am going to synchronize the finalizer goroutine with the rest of the world in racefingo(). This is closer to what happens in reality and so does not have false positives. And also add README file with instructions how to build the runtime.

Patch Set 1 #

Patch Set 2 : diff -r b661b713984f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r e3d1b93bfa09 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r e3d1b93bfa09 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 34142c2654fd https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 1

Patch Set 6 : diff -r 34142c2654fd https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r 97c0a0267c36 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M src/pkg/runtime/mgc0.c View 1 2 chunks +2 lines, -3 lines 0 comments Download
A src/pkg/runtime/race/README View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
M src/pkg/runtime/race/race_darwin_amd64.syso View 1 2 3 4 Binary file 0 comments Download
M src/pkg/runtime/race/race_linux_amd64.syso View 1 2 3 4 Binary file 0 comments Download
M src/pkg/runtime/race/race_windows_amd64.syso View 1 2 3 4 Binary file 0 comments Download

Messages

Total messages: 8
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 10 months ago (2012-11-08 14:27:59 UTC) #1
dvyukov
On 2012/11/08 14:27:59, dvyukov wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
9 years, 10 months ago (2012-11-09 11:24:00 UTC) #2
minux1
please update the description. https://codereview.appspot.com/6810095/diff/5002/src/pkg/runtime/race/README File src/pkg/runtime/race/README (right): https://codereview.appspot.com/6810095/diff/5002/src/pkg/runtime/race/README#newcode10 src/pkg/runtime/race/README:10: You may need gcc >= ...
9 years, 10 months ago (2012-11-09 11:29:28 UTC) #3
dvyukov
On 2012/11/09 11:29:28, minux wrote: > please update the description. Done. > https://codereview.appspot.com/6810095/diff/5002/src/pkg/runtime/race/README > File ...
9 years, 10 months ago (2012-11-09 11:31:55 UTC) #4
dvyukov
On 2012/11/09 11:31:55, dvyukov wrote: > On 2012/11/09 11:29:28, minux wrote: > > please update ...
9 years, 10 months ago (2012-11-09 11:43:38 UTC) #5
minux1
On Fri, Nov 9, 2012 at 7:43 PM, <dvyukov@google.com> wrote: > > Seem to work ...
9 years, 10 months ago (2012-11-11 17:48:41 UTC) #6
rsc
LGTM
9 years, 10 months ago (2012-11-12 20:41:03 UTC) #7
dvyukov
9 years, 10 months ago (2012-11-14 13:23:50 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=d1854dd425b2 ***

runtime/race: more precise handling of finalizers
Currently race detector runtime just disables race detection in the finalizer
goroutine.
It has false positives when a finalizer writes to shared memory -- the race with
finalizer is reported in a normal goroutine that accesses the same memory.
After this change I am going to synchronize the finalizer goroutine with the
rest of the world in racefingo(). This is closer to what happens in reality and
so
does not have false positives.
And also add README file with instructions how to build the runtime.

R=golang-dev, minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6810095
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b