Issue 67850044: code review 67850044: runtime: fix double symbol definition (Closed)
Descriptionruntime: fix double symbol definition
runfinqv is already defined the same way on line 271.
There may also be something to fix in compiler/linker wrt diagnostics.
Fixes issue 7375.
Patch Set 1 #Patch Set 2 : diff -r 3cf533be5e36 https://dvyukov%40google.com@code.google.com/p/go/ #Patch Set 3 : diff -r 3cf533be5e36 https://dvyukov%40google.com@code.google.com/p/go/ #Patch Set 4 : diff -r 3cd2d73261f5 https://dvyukov%40google.com@code.google.com/p/go/ #
Total comments: 2
MessagesTotal messages: 13
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
Sign in to reply to this message.
On 2014/02/24 10:14:28, dvyukov wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review this change to > https://dvyukov%40google.com@code.google.com/p/go/ May also fix https://code.google.com/p/go/issues/detail?id=7338 and/or https://code.google.com/p/go/issues/detail?id=7347
Sign in to reply to this message.
On 2014/02/24 10:22:05, dfc wrote: > On 2014/02/24 10:14:28, dvyukov wrote: > > Hello mailto:golang-codereviews@googlegroups.com, > > > > I'd like you to review this change to > > https://dvyukov%40google.com@code.google.com/p/go/ > > May also fix https://code.google.com/p/go/issues/detail?id=7338 and/or > https://code.google.com/p/go/issues/detail?id=7347 I can't verify and I don't see runfinq in these stack traces.
Sign in to reply to this message.
LGTM On Mon, Feb 24, 2014 at 2:14 AM, <dvyukov@google.com> wrote: > Reviewers: golang-codereviews, > > Message: > Hello golang-codereviews@googlegroups.com, > > I'd like you to review this change to > https://dvyukov%40google.com@code.google.com/p/go/ > > > Description: > runtime: fix double symbol definition > Fixes issue 7375. > > Please review this at https://codereview.appspot.com/67850044/ > > Affected files (+0, -2 lines): > M src/pkg/runtime/mgc0.c > > > Index: src/pkg/runtime/mgc0.c > =================================================================== > --- a/src/pkg/runtime/mgc0.c > +++ b/src/pkg/runtime/mgc0.c > @@ -2182,8 +2182,6 @@ > return runtime·atoi(p); > } > > -static FuncVal runfinqv = {runfinq}; > - > void > runtime·gc(int32 force) > { > > > -- > You received this message because you are subscribed to the Google Groups > "golang-codereviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to golang-codereviews+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. >
Sign in to reply to this message.
*** Submitted as https://code.google.com/p/go/source/detail?r=5ae089f46a43 *** runtime: fix double symbol definition runfinqv is already defined the same way on line 271. There may also be something to fix in compiler/linker wrt diagnostics. Fixes issue 7375. LGTM=bradfitz R=golang-codereviews, dave, bradfitz CC=golang-codereviews https://codereview.appspot.com/67850044
Sign in to reply to this message.
first successful build on dragonfly! On Mon, Feb 24, 2014 at 8:23 PM, <dvyukov@google.com> wrote: > *** Submitted as > https://code.google.com/p/go/source/detail?r=5ae089f46a43 *** > > > runtime: fix double symbol definition > runfinqv is already defined the same way on line 271. > There may also be something to fix in compiler/linker wrt diagnostics. > Fixes issue 7375. > > LGTM=bradfitz > R=golang-codereviews, dave, bradfitz > CC=golang-codereviews > https://codereview.appspot.com/67850044 > > > https://codereview.appspot.com/67850044/
Sign in to reply to this message.
On Mon, Feb 24, 2014 at 8:33 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > first successful build on dragonfly! At least first in a while. It had a bunch early on in its life too. Unfortunately it didn't last long. Broken again. Why did the C compiler allow that duplication symbol definition in the first place? Bug open for that?
Sign in to reply to this message.
Message was sent while issue was closed.
On 2014/02/24 16:37:22, bradfitz wrote: > On Mon, Feb 24, 2014 at 8:33 AM, Dmitry Vyukov <mailto:dvyukov@google.com> wrote: > > > first successful build on dragonfly! > > > At least first in a while. It had a bunch early on in its life too. > > Unfortunately it didn't last long. Broken again. > > Why did the C compiler allow that duplication symbol definition in the > first place? Bug open for that? +rsc I have not opened a bug
Sign in to reply to this message.
Message was sent while issue was closed.
i am not going to chase that down in the c compiler. no thanks.
Sign in to reply to this message.
I didn't know I could be more afraid of that code. On Mon, Feb 24, 2014 at 8:55 AM, <rsc@golang.org> wrote: > i am not going to chase that down in the c compiler. no thanks. > > > https://codereview.appspot.com/67850044/ >
Sign in to reply to this message.
Message was sent while issue was closed.
This CL appears to have broken the linux-amd64-race builder.
Sign in to reply to this message.
Message was sent while issue was closed.
https://codereview.appspot.com/67850044/diff/40001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (left): https://codereview.appspot.com/67850044/diff/40001/src/pkg/runtime/mgc0.c#old... src/pkg/runtime/mgc0.c:2185: static FuncVal runfinqv = {runfinq}; This is still in tip: http://tip.golang.org/src/pkg/runtime/mgc0.c#L261
Sign in to reply to this message.
Message was sent while issue was closed.
https://codereview.appspot.com/67850044/diff/40001/src/pkg/runtime/mgc0.c File src/pkg/runtime/mgc0.c (left): https://codereview.appspot.com/67850044/diff/40001/src/pkg/runtime/mgc0.c#old... src/pkg/runtime/mgc0.c:2185: static FuncVal runfinqv = {runfinq}; On 2014/03/12 13:15:59, aram wrote: > This is still in tip: http://tip.golang.org/src/pkg/runtime/mgc0.c#L261 Ah, no, false alarm.
Sign in to reply to this message.
|
