Issue 6782135: code review 6782135: codereview: always use HTTPS

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6782135: code review 6782135: codereview: always use HTTPS (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by bradfitz

Modified:
11 years, 4 months ago

Reviewers:
rsc

CC:
golang-dev

Visibility:
Public.

Description

codereview: always use HTTPS The new version of rietveld pushed 1.5 hours ago requires HTTPS now, otherwise it issues a 301 to HTTPS which we barfed on.

Patch Set 1 #

Patch Set 2 : diff -r 88e4ba173900 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 88e4ba173900 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b44754d79b3f https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	lib/codereview/codereview.py	View	1	7 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 4 months ago (2012-11-29 19:18:01 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=4d1c9e968c62 *** codereview: always use HTTPS The new version of rietveld pushed ...

11 years, 4 months ago (2012-11-29 19:20:06 UTC) #2

rsc

11 years, 4 months ago (2012-11-29 19:32:39 UTC) #3

LGTM

This is going to break people who are using alternate servers that
don't support https but let's fix that later.

Expand All Messages | Collapse All Messages