Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 6782097: code review 6782097: cmd/cgo: bool alignment/padding issue.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by Vova616
Modified:
9 years, 7 months ago
Reviewers:
iant
CC:
golang-dev, iant, minux1, bradfitz, vova616_gmail.com
Visibility:
Public.

Description

cmd/cgo: fix alignment of bool. Fixes issue 4417.

Patch Set 1 #

Patch Set 2 : diff -r 2a4a89b1f36b https://code.google.com/p/go #

Total comments: 2

Patch Set 3 : diff -r 2a4a89b1f36b https://code.google.com/p/go #

Patch Set 4 : diff -r 2a4a89b1f36b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -3 lines) Patch
M misc/cgo/test/cgo_test.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A misc/cgo/test/issue4417.go View 1 2 1 chunk +44 lines, -0 lines 0 comments Download
M src/cmd/cgo/gcc.go View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16
Vova616
Hello golang-dev@googlegroups.com (cc: vova616@gmail.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2012-11-21 11:32:10 UTC) #1
Vova616
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, vova616@gmail.com), Please take another look.
9 years, 7 months ago (2012-11-21 11:33:43 UTC) #2
Vova616
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, vova616@gmail.com), Please take another look.
9 years, 7 months ago (2012-11-21 11:37:19 UTC) #3
iant
Have you signed the CLA? https://codereview.appspot.com/6782097/diff/2001/test/fixedbugs/issue4417.go File test/fixedbugs/issue4417.go (right): https://codereview.appspot.com/6782097/diff/2001/test/fixedbugs/issue4417.go#newcode25 test/fixedbugs/issue4417.go:25: print("found ", b, " ...
9 years, 7 months ago (2012-11-21 14:06:11 UTC) #4
minux1
please put the cgo test file to misc/cgo/test/.
9 years, 7 months ago (2012-11-21 15:33:13 UTC) #5
bradfitz
https://codereview.appspot.com/6782097/diff/2001/test/fixedbugs/issue4417.go File test/fixedbugs/issue4417.go (right): https://codereview.appspot.com/6782097/diff/2001/test/fixedbugs/issue4417.go#newcode34 test/fixedbugs/issue4417.go:34: if b != 3 { run gofmt on this ...
9 years, 7 months ago (2012-11-21 16:11:13 UTC) #6
Vova616
On 2012/11/21 14:06:11, iant wrote: > Have you signed the CLA? > > https://codereview.appspot.com/6782097/diff/2001/test/fixedbugs/issue4417.go > ...
9 years, 7 months ago (2012-11-21 16:43:35 UTC) #7
minux1
On Thu, Nov 22, 2012 at 12:43 AM, <Vova616@gmail.com> wrote: > how do I do ...
9 years, 7 months ago (2012-11-21 16:45:02 UTC) #8
Vova616
Hello golang-dev@googlegroups.com, iant@golang.org, minux.ma@gmail.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com, vova616@gmail.com), Please take another look.
9 years, 7 months ago (2012-11-21 17:15:35 UTC) #9
Vova616
Hello golang-dev@googlegroups.com, iant@golang.org, minux.ma@gmail.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com, vova616@gmail.com), Please take another look.
9 years, 7 months ago (2012-11-21 17:40:18 UTC) #10
Vova616
On 2012/11/21 16:45:02, minux wrote: > On Thu, Nov 22, 2012 at 12:43 AM, <mailto:Vova616@gmail.com> ...
9 years, 7 months ago (2012-11-21 17:44:13 UTC) #11
iant
Please change the first line of the CL description to cmd/cgo: fix alignment of bool ...
9 years, 7 months ago (2012-11-21 19:49:32 UTC) #12
Vova616
On 2012/11/21 19:49:32, iant wrote: > Please change the first line of the CL description ...
9 years, 7 months ago (2012-11-21 20:16:40 UTC) #13
iant
LGTM
9 years, 7 months ago (2012-11-21 20:53:42 UTC) #14
iant
Thanks.
9 years, 7 months ago (2012-11-21 20:54:06 UTC) #15
iant
9 years, 7 months ago (2012-11-21 21:04:44 UTC) #16
*** Submitted as http://code.google.com/p/go/source/detail?r=dfb4a24735c0 ***

cmd/cgo: fix alignment of bool.
Fixes issue 4417.

R=golang-dev, iant, minux.ma, bradfitz
CC=golang-dev, vova616
http://codereview.appspot.com/6782097

Committer: Ian Lance Taylor <iant@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b