Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(532)

Issue 6767045: code review 6767045: crypto/x509: add support for SEC1/EC private keys. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by jsing
Modified:
9 years, 10 months ago
Reviewers:
CC:
agl1, golang-dev
Visibility:
Public.

Description

crypto/x509: add support for SEC1/EC private keys. Add support for parsing SEC1 EC private keys and PKCS8 encapsulated EC private key structures.

Patch Set 1 : diff -r b685816af832 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r b685816af832 https://go.googlecode.com/hg/ #

Total comments: 15

Patch Set 3 : diff -r b685816af832 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r d9896259d8e5 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 76ff7da868c6 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -7 lines) Patch
M src/pkg/crypto/x509/pkcs8.go View 1 2 3 3 chunks +16 lines, -2 lines 0 comments Download
M src/pkg/crypto/x509/pkcs8_test.go View 1 chunk +13 lines, -5 lines 0 comments Download
A src/pkg/crypto/x509/sec1.go View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
A src/pkg/crypto/x509/sec1_test.go View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11
jsing
Hello agl@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 11 months ago (2012-10-25 13:25:57 UTC) #1
agl1
https://codereview.appspot.com/6767045/diff/8001/src/pkg/crypto/x509/sec1.go File src/pkg/crypto/x509/sec1.go (right): https://codereview.appspot.com/6767045/diff/8001/src/pkg/crypto/x509/sec1.go#newcode32 src/pkg/crypto/x509/sec1.go:32: func ParseSEC1PrivateKey(der []byte) (key *ecdsa.PrivateKey, err error) { Where ...
9 years, 11 months ago (2012-10-25 14:19:03 UTC) #2
jsing
https://codereview.appspot.com/6767045/diff/8001/src/pkg/crypto/x509/sec1.go File src/pkg/crypto/x509/sec1.go (right): https://codereview.appspot.com/6767045/diff/8001/src/pkg/crypto/x509/sec1.go#newcode32 src/pkg/crypto/x509/sec1.go:32: func ParseSEC1PrivateKey(der []byte) (key *ecdsa.PrivateKey, err error) { On ...
9 years, 11 months ago (2012-10-25 15:20:57 UTC) #3
agl1
https://codereview.appspot.com/6767045/diff/8001/src/pkg/crypto/x509/sec1.go File src/pkg/crypto/x509/sec1.go (right): https://codereview.appspot.com/6767045/diff/8001/src/pkg/crypto/x509/sec1.go#newcode32 src/pkg/crypto/x509/sec1.go:32: func ParseSEC1PrivateKey(der []byte) (key *ecdsa.PrivateKey, err error) { On ...
9 years, 11 months ago (2012-10-29 13:46:37 UTC) #4
jsing
On 2012/10/29 13:46:37, agl1 wrote: > https://codereview.appspot.com/6767045/diff/8001/src/pkg/crypto/x509/sec1.go > File src/pkg/crypto/x509/sec1.go (right): > > https://codereview.appspot.com/6767045/diff/8001/src/pkg/crypto/x509/sec1.go#newcode32 > ...
9 years, 10 months ago (2012-11-13 14:03:13 UTC) #5
agl1
https://codereview.appspot.com/6767045/diff/11001/src/pkg/crypto/x509/sec1.go File src/pkg/crypto/x509/sec1.go (right): https://codereview.appspot.com/6767045/diff/11001/src/pkg/crypto/x509/sec1.go#newcode41 src/pkg/crypto/x509/sec1.go:41: func ParseECPrivateKey(der []byte) (key *ecdsa.PrivateKey, err error) { I ...
9 years, 10 months ago (2012-11-13 15:43:12 UTC) #6
jsing
On 14 November 2012 02:43, <agl@golang.org> wrote: > > https://codereview.appspot.com/6767045/diff/11001/src/pkg/crypto/x509/sec1.go > File src/pkg/crypto/x509/sec1.go (right): > ...
9 years, 10 months ago (2012-11-13 15:57:02 UTC) #7
agl1
On Tue, Nov 13, 2012 at 10:57 AM, Joel Sing <jsing@google.com> wrote: > If the ...
9 years, 10 months ago (2012-11-13 16:35:12 UTC) #8
jsing
On 2012/11/13 16:35:12, agl1 wrote: > On Tue, Nov 13, 2012 at 10:57 AM, Joel ...
9 years, 10 months ago (2012-11-14 10:39:56 UTC) #9
agl1
LGTM. (Let me know if you need me to land it in the tree.)
9 years, 10 months ago (2012-11-14 16:27:48 UTC) #10
jsing
9 years, 10 months ago (2012-11-14 16:41:00 UTC) #11
*** Submitted as http://code.google.com/p/go/source/detail?r=15a03e58cd8d ***

crypto/x509: add support for SEC1/EC private keys.

Add support for parsing SEC1 EC private keys and PKCS8 encapsulated
EC private key structures.

R=agl
CC=golang-dev
http://codereview.appspot.com/6767045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b