Issue 6750055: Fixes tests relying on /etc/lsb-release

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6750055: Fixes tests relying on /etc/lsb-release

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by clint.byrum

Modified:
8 years, 7 months ago

Reviewers:
jimbaker, mp+130929

Visibility:
Public.

Description

Fixes tests relying on /etc/lsb-release Fixes tests relying on /etc/lsb-release https://code.launchpad.net/~clint-fewbar/juju/no-lsb-release/+merge/130929 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	juju/charm/tests/test_directory.py	View		1 chunk	+10 lines, -8 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

jimbaker

11 years, 5 months ago (2012-10-24 23:48:47 UTC) #2

+1, LGTM, with the following coding convention minor addressed.

https://codereview.appspot.com/6750055/diff/1/juju/charm/tests/test_directory.py
File juju/charm/tests/test_directory.py (right):

https://codereview.appspot.com/6750055/diff/1/juju/charm/tests/test_directory...
juju/charm/tests/test_directory.py:215: with
tempfile.NamedTemporaryFile(dir='/tmp') as external_file:
Use the makeFile method on our TestCase; it constructs a temporary file as
above, but also ensures it is deleted at the end of the test. This method is
used throughout our tests, so this will help with following current coding
conventions.

external_file = self.makeFile()

https://codereview.appspot.com/6750055/diff/1/juju/charm/tests/test_directory...
juju/charm/tests/test_directory.py:224: with
tempfile.NamedTemporaryFile(dir='/tmp') as external_file:
Ditto.

Expand All Messages | Collapse All Messages