Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(829)

Side by Side Diff: src/cmd/go/test.bash

Issue 6741050: code review 6741050: cmd/go: make package list order predicable (Closed)
Patch Set: diff -r caf040d030f3 https://code.google.com/p/go/ Created 11 years, 5 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/cmd/go/pkg.go ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/bash 1 #!/bin/bash
2 # Copyright 2012 The Go Authors. All rights reserved. 2 # Copyright 2012 The Go Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style 3 # Use of this source code is governed by a BSD-style
4 # license that can be found in the LICENSE file. 4 # license that can be found in the LICENSE file.
5 5
6 set -e 6 set -e
7 go build -o testgo 7 go build -o testgo
8 8
9 ok=true 9 ok=true
10 10
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
135 echo 'GOPATH=":$(pwd)/testdata:." go build should have failed, did not' 135 echo 'GOPATH=":$(pwd)/testdata:." go build should have failed, did not'
136 ok=false 136 ok=false
137 fi 137 fi
138 138
139 # issue 4104 139 # issue 4104
140 if [ $(./testgo test fmt fmt fmt fmt fmt | wc -l) -ne 1 ] ; then 140 if [ $(./testgo test fmt fmt fmt fmt fmt | wc -l) -ne 1 ] ; then
141 echo 'go test fmt fmt fmt fmt fmt tested the same package multiple times' 141 echo 'go test fmt fmt fmt fmt fmt tested the same package multiple times'
142 ok=false 142 ok=false
143 fi 143 fi
144 144
145 # ensure that output of 'go list' is consistent between runs
146 ./testgo list std > test_std.list
147 if ! ./testgo list std | cmp -s test_std.list - ; then
148 echo "go list std doesn't show in consistent order"
bradfitz 2012/10/19 15:19:30 "go list std ordering is inconsistent" ?
minux1 2012/10/20 09:25:24 Oh, yeah, this is much better. thanks.
149 ok=false
150 fi
151 rm -f test_std.list
152
153 # clean up
154 rm -rf testdata/bin testdata/bin1
155 rm -f testgo
156
145 if $ok; then 157 if $ok; then
146 echo PASS 158 echo PASS
147 else 159 else
148 echo FAIL 160 echo FAIL
149 exit 1 161 exit 1
150 fi 162 fi
OLDNEW
« no previous file with comments | « src/cmd/go/pkg.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b