Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(50)

Issue 6741050: code review 6741050: cmd/go: make package list order predicable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by minux1
Modified:
9 years, 10 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

cmd/go: make package list order predicable also add a cleanup phase to cmd/go/test.bash.

Patch Set 1 #

Patch Set 2 : diff -r caf040d030f3 https://code.google.com/p/go/ #

Patch Set 3 : diff -r caf040d030f3 https://code.google.com/p/go/ #

Patch Set 4 : diff -r caf040d030f3 https://code.google.com/p/go/ #

Patch Set 5 : diff -r caf040d030f3 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 6 : diff -r 779d5b8f59bf https://code.google.com/p/go/ #

Patch Set 7 : diff -r 779d5b8f59bf https://code.google.com/p/go/ #

Patch Set 8 : diff -r 8a8a88122a40 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M src/cmd/go/pkg.go View 1 1 chunk +4 lines, -5 lines 0 comments Download
M src/cmd/go/test.bash View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 10 months ago (2012-10-19 14:10:18 UTC) #1
bradfitz
LGTM https://codereview.appspot.com/6741050/diff/5003/src/cmd/go/test.bash File src/cmd/go/test.bash (right): https://codereview.appspot.com/6741050/diff/5003/src/cmd/go/test.bash#newcode148 src/cmd/go/test.bash:148: echo "go list std doesn't show in consistent ...
9 years, 10 months ago (2012-10-19 15:19:29 UTC) #2
minux1
9 years, 10 months ago (2012-10-20 09:25:24 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=6653eb72fd46 ***

cmd/go: make package list order predicable
also add a cleanup phase to cmd/go/test.bash.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6741050

http://codereview.appspot.com/6741050/diff/5003/src/cmd/go/test.bash
File src/cmd/go/test.bash (right):

http://codereview.appspot.com/6741050/diff/5003/src/cmd/go/test.bash#newcode148
src/cmd/go/test.bash:148: echo "go list std doesn't show in consistent order"
On 2012/10/19 15:19:30, bradfitz wrote:
> "go list std ordering is inconsistent"
Oh, yeah, this is much better. thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b