Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 6739047: freetype/fontconfig support for fontsrv

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 5 months ago by paulzhol
Modified:
2 years, 5 months ago
Reviewers:
rsc
CC:
rsc, 0intro, codebot
Visibility:
Public.

Patch Set 1 : freetype/fontconfig support for plan9port's fontsrv #

Patch Set 2 : freetype/fontconfig support for plan9port's fontsrv #

Total comments: 1

Patch Set 3 : freetype/fontconfig support for plan9port's fontsrv #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -3 lines) Patch
M src/cmd/fontsrv/a.h View 1 chunk +4 lines, -0 lines 0 comments Download
A src/cmd/fontsrv/freetyperules.sh View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/cmd/fontsrv/mkfile View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/cmd/fontsrv/x11.c View 1 2 1 chunk +261 lines, -2 lines 0 comments Download

Messages

Total messages: 10
paulzhol
2 years, 5 months ago (2012-10-20 16:54:21 UTC) #1
paulzhol
2 years, 5 months ago (2012-10-20 16:57:36 UTC) #2
0intro
Very cool stuff. Thank you. You should remove heading tabs in empty lines in x11.c.
2 years, 5 months ago (2012-10-20 19:55:30 UTC) #3
paulzhol
2 years, 5 months ago (2012-10-20 21:09:22 UTC) #4
paulzhol
Thanks, I've updated. There are some minor issues though: With some fonts, when typing in ...
2 years, 5 months ago (2012-10-20 21:28:24 UTC) #5
rsc
Thanks very much! https://codereview.appspot.com/6739047/diff/4002/src/cmd/devdraw/mkwsysrules.sh File src/cmd/devdraw/mkwsysrules.sh (right): https://codereview.appspot.com/6739047/diff/4002/src/cmd/devdraw/mkwsysrules.sh#newcode51 src/cmd/devdraw/mkwsysrules.sh:51: echo 'LDFLAGS=$LDFLAGS -lfontconfig -lfreetype -lz' I ...
2 years, 5 months ago (2012-10-21 16:57:18 UTC) #6
paulzhol
On 2012/10/21 16:57:18, rsc wrote: > I am a little worried about requiring these for ...
2 years, 5 months ago (2012-10-21 20:10:13 UTC) #7
rsc
I expect this to break for some people, but we can deal with that when ...
2 years, 5 months ago (2012-10-21 20:35:46 UTC) #8
rsc
LGTM
2 years, 5 months ago (2012-10-21 20:35:49 UTC) #9
rsc
2 years, 5 months ago (2012-10-21 20:49:16 UTC) #10
*** Submitted as http://code.google.com/p/plan9port/source/detail?r=c73dece4c822
***

fontsrv: x11 support

R=rsc, 0intro
CC=plan9port.codebot
http://codereview.appspot.com/6739047

Committer: Russ Cox <rsc@swtch.com>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5