Issue 6721056: code review 6721056: crypto/des: add an example to demonstrate EDE2 operation.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6721056: code review 6721056: crypto/des: add an example to demonstrate EDE2 operation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by agl1

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

crypto/des: add an example to demonstrate EDE2 operation. EDE2 is a rare DES mode that can be implemented with crypto/des, but it's somewhat non-obvious so this CL adds an example of doing so. Fixes issue 3537.

Patch Set 1 #

Patch Set 2 : diff -r 95b8a6011b40 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 95b8a6011b40 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 1d9ea73cf6c1 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 535511012f51 https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	src/pkg/crypto/des/des_test.go	View	1 2 3	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 6 months ago (2012-10-17 23:37:37 UTC) #1

adg

https://codereview.appspot.com/6721056/diff/3001/src/pkg/crypto/des/des_test.go File src/pkg/crypto/des/des_test.go (right): https://codereview.appspot.com/6721056/diff/3001/src/pkg/crypto/des/des_test.go#newcode1513 src/pkg/crypto/des/des_test.go:1513: tripleDESKey = append(tripleDESKey, ede2Key[:16]) does this compile? shouldn't it ...

11 years, 5 months ago (2012-11-13 11:56:29 UTC) #3

agl1

11 years, 5 months ago (2012-11-13 16:39:20 UTC) #4

agl1

11 years, 4 months ago (2012-12-22 15:50:28 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=df1405f02219 ***

crypto/des: add an example to demonstrate EDE2 operation.

EDE2 is a rare DES mode that can be implemented with crypto/des, but
it's somewhat non-obvious so this CL adds an example of doing so.

Fixes issue 3537.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/6721056

Expand All Messages | Collapse All Messages