Issue 6718052: state, machiner: new style principal units watcher

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6718052: state, machiner: new style principal units watcher

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by aram

Modified:
11 years, 6 months ago

Reviewers:
mp+130122, niemeyer

Visibility:
Public.

Description

state, machiner: new style principal units watcher Convert the machine principal units watcher to then new, id only, model and refactor the machiner to make use of it. https://code.launchpad.net/~aramh/juju-core/109-state-machiner-watchers-machine-principals6/+merge/130122 Requires: https://code.launchpad.net/~aramh/juju-core/108-firewaller-new-watcher-units6/+merge/130119 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state, machiner: new style principal units watcher #

Patch Set 3 : state, machiner: new style principal units watcher #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+416 lines, -413 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	state/machine_test.go	View	2 chunks	+248 lines, -256 lines	0 comments	Download
M	state/unit.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	state/watcher.go	View	3 chunks	+133 lines, -140 lines	0 comments	Download
M	worker/machiner/export_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	worker/machiner/machiner.go	View	3 chunks	+19 lines, -12 lines	0 comments	Download
M	worker/machiner/machiner_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Please propose again when the pre-req is sorted out.

Expand All Messages | Collapse All Messages