Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(33)

Issue 67107: collapse_address_list is too slow

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by Matthew Flanagan
Modified:
7 years, 6 months ago
Reviewers:
Base URL:
http://ipaddr-py.googlecode.com/svn/trunk/
Visibility:
Public.

Description

See ipaddr issue http://code.google.com/p/ipaddr-py/issues/detail?id=17

Patch Set 1 #

Patch Set 2 : uncommented new code #

Patch Set 3 : removed range notation #

Total comments: 2

Patch Set 4 : New patch to work with 2.0.x branch. Added _hash_() method to BaseIP class for set() to work. #

Patch Set 5 : Up to 2x faster version of previous patch. #

Patch Set 6 : Treat a list of /32 or /128 Networks as IP addresses so collapse_address_list can summarize them. #

Total comments: 6

Patch Set 7 : Fixes for comments on Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -3 lines) Patch
M ipaddr.py View 1 2 3 4 5 6 7 chunks +150 lines, -1 line 0 comments Download
M ipaddr_test.py View 1 2 3 4 chunks +70 lines, -2 lines 0 comments Download

Messages

Total messages: 10
Peter Moody
Matt, can you upload a patch against the current version? there have been some updates ...
7 years, 9 months ago (2009-06-02 18:27:12 UTC) #1
Peter Moody
can you fix up the docstrings here to be more explicit about Args: Returns: etc? ...
7 years, 9 months ago (2009-06-02 21:05:19 UTC) #2
Matthew Flanagan
7 years, 7 months ago (2009-08-19 11:03:58 UTC) #3
Matthew Flanagan
Patchset 5 is up to 2x faster than Patchset 4: $ python summarize_test.py summarize_address_range(IP('0.0.0.0',host=True),IP('255.255.255.254',host=True)): 27.5853071213 ...
7 years, 7 months ago (2009-08-19 12:38:07 UTC) #4
Matthew Flanagan
7 years, 7 months ago (2009-08-20 00:37:48 UTC) #5
Peter Moody
http://codereview.appspot.com/67107/diff/2006/2008 File ipaddr.py (right): http://codereview.appspot.com/67107/diff/2006/2008#newcode252 Line 252: raise IPTypeError("first and last must be IP addresses ...
7 years, 7 months ago (2009-08-20 18:21:17 UTC) #6
Matthew Flanagan
Fixes in Patch Set 7 http://codereview.appspot.com/67107/diff/2006/2008 File ipaddr.py (right): http://codereview.appspot.com/67107/diff/2006/2008#newcode252 Line 252: raise IPTypeError("first and ...
7 years, 7 months ago (2009-08-21 00:55:56 UTC) #7
Matthew Flanagan
7 years, 7 months ago (2009-08-21 01:02:12 UTC) #8
Peter Moody
On 2009/08/21 01:02:12, Matthew Flanagan wrote: > LGTM. i'll apply/commit this.
7 years, 7 months ago (2009-08-21 17:02:25 UTC) #9
Peter Moody
7 years, 6 months ago (2009-09-11 16:51:14 UTC) #10

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted