Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(117)

Issue 66990047: Start and Stop functionality with Failure and Repair model

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by Vedran Miletić
Modified:
2 years, 6 months ago
Visibility:
Public.

Description

Start and Stop functionality with Failure and Repair model

Patch Set 1 #

Total comments: 9

Patch Set 2 : Remove TimeUnitInformation stuff #

Patch Set 3 : Updated per Tommaso's comments #

Patch Set 4 : Updated and rebased patch set, FailureRepairModel tests still missing #

Patch Set 5 : Rebase and add sleep/wake support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2192 lines, -0 lines) Patch
M doc/manual/source/index.rst View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A doc/manual/source/start-stop-functionality.rst View 1 2 3 4 1 chunk +81 lines, -0 lines 0 comments Download
A src/core/model/resumable-object.h View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
A src/core/model/resumable-object.cc View 1 2 3 4 1 chunk +58 lines, -0 lines 0 comments Download
A src/core/model/sleep-wake-functionality.h View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
A src/core/model/sleep-wake-functionality.cc View 1 2 3 4 1 chunk +71 lines, -0 lines 0 comments Download
A src/core/model/stop-restart-functionality.h View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
A src/core/model/stop-restart-functionality.cc View 1 2 3 4 1 chunk +71 lines, -0 lines 0 comments Download
A src/core/model/stoppable-and-resumable-object.h View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
A src/core/model/stoppable-and-resumable-object.cc View 1 2 3 4 1 chunk +66 lines, -0 lines 0 comments Download
A src/core/model/stoppable-object.h View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
A src/core/model/stoppable-object.cc View 1 2 3 4 1 chunk +58 lines, -0 lines 0 comments Download
M src/core/model/vector.h View 1 2 3 4 6 chunks +94 lines, -0 lines 0 comments Download
M src/core/model/vector.cc View 1 2 3 4 5 chunks +82 lines, -0 lines 0 comments Download
A src/core/test/start-stop-functionality-test-suite.cc View 1 2 3 4 1 chunk +181 lines, -0 lines 0 comments Download
M src/core/wscript View 1 2 3 4 3 chunks +11 lines, -0 lines 0 comments Download
A src/failure-repair/doc/failure-repair.rst View 1 2 3 4 1 chunk +89 lines, -0 lines 0 comments Download
A src/failure-repair/examples/failure-repair-example.cc View 1 2 3 4 1 chunk +98 lines, -0 lines 0 comments Download
A src/failure-repair/examples/wscript View 1 chunk +6 lines, -0 lines 0 comments Download
A src/failure-repair/helper/failure-repair-helper.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/failure-repair/helper/failure-repair-helper.cc View 1 chunk +29 lines, -0 lines 0 comments Download
A src/failure-repair/helper/failure-repair-time-tracker-container.h View 1 chunk +97 lines, -0 lines 0 comments Download
A src/failure-repair/helper/failure-repair-time-tracker-container.cc View 1 chunk +90 lines, -0 lines 0 comments Download
A src/failure-repair/model/failure-repair-model.h View 1 1 chunk +118 lines, -0 lines 0 comments Download
A src/failure-repair/model/failure-repair-model.cc View 1 1 chunk +198 lines, -0 lines 0 comments Download
A src/failure-repair/test/failure-repair-test-suite.cc View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
A src/failure-repair/utils/failure-repair-time-tracker.h View 1 2 1 chunk +131 lines, -0 lines 0 comments Download
A src/failure-repair/utils/failure-repair-time-tracker.cc View 1 1 chunk +194 lines, -0 lines 0 comments Download
A src/failure-repair/wscript View 1 2 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Tommaso Pecorella
Hi, first bunch of comments. However, I have one general comment: why we don't add ...
4 years, 6 months ago (2014-03-22 17:24:10 UTC) #1
Peter Barnes
I've got a better way to handle printing Time in a specific unit, which I'll ...
4 years, 5 months ago (2014-03-26 23:44:56 UTC) #2
Peter Barnes
Done, r10688, ad36a71c737c On 2014/03/26 23:44:56, Peter Barnes wrote: > I've got a better way ...
4 years, 5 months ago (2014-04-03 01:50:18 UTC) #3
Vedran Miletić
On 2014/03/22 17:24:10, Tommaso Pecorella wrote: > Hi, > first bunch of comments. > > ...
4 years, 5 months ago (2014-04-06 15:16:28 UTC) #4
Vedran Miletić
4 years, 5 months ago (2014-04-06 15:38:13 UTC) #5
On 2014/04/03 01:50:18, Peter Barnes wrote:
> Done, r10688, ad36a71c737c
> 
> On 2014/03/26 23:44:56, Peter Barnes wrote:
> > I've got a better way to handle printing Time in a specific unit, which I'll

Hi Peter,

I'm not using this at the moment since TimeUnitInformation got replaced by
Time::FromDouble. However, I see a possibility for pretty printing total uptime
and downtime in a specific time unit which could be quite neat.

Regards,
Vedran
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b