Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(79)

Issue 6682050: code review 6682050: runtime: fix spurious deadlock crashes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by dvyukov
Modified:
10 years, 1 month ago
Reviewers:
CC:
golang-dev, iant2, Sebastien Paolacci
Visibility:
Public.

Description

runtime: fix spurious deadlock crashes Fixes issue 4243.

Patch Set 1 #

Patch Set 2 : diff -r 3e39b4ebe5b1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 3e39b4ebe5b1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 3e39b4ebe5b1 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r b154a456c78c https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M src/pkg/runtime/mheap.c View 1 2 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 6
dvyukov
Hello golang-dev@googlegroups.com (cc: sebastien.paolacci@gmail.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 1 month ago (2012-10-15 11:20:59 UTC) #1
dvyukov
I do not want to touch the deadlock detection logic, so I moved GC from ...
10 years, 1 month ago (2012-10-15 11:22:09 UTC) #2
iant2
LGTM On Mon, Oct 15, 2012 at 4:20 AM, <dvyukov@google.com> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
10 years, 1 month ago (2012-10-15 16:49:18 UTC) #3
Sebastien Paolacci
LGTM. I can't think I've never thought about that one, nor observed any crash (and ...
10 years, 1 month ago (2012-10-15 18:59:15 UTC) #4
dvyukov
On 2012/10/15 18:59:15, Sebastien Paolacci wrote: > LGTM. I can't think I've never thought about ...
10 years, 1 month ago (2012-10-16 10:41:18 UTC) #5
dvyukov
10 years, 1 month ago (2012-10-16 10:41:47 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=c99bbf5b161f ***

runtime: fix spurious deadlock crashes
Fixes issue 4243.

R=golang-dev, iant
CC=golang-dev, sebastien.paolacci
http://codereview.appspot.com/6682050
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b