code review 6682046: container/list: fix typo

container/list: fix typo

[taj, 2012-10-13 16:51:24]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[albert.strasheim, 2012-10-13 17:09:23]

https://codereview.appspot.com/6682046/diff/3/src/pkg/container/list/list.go
File src/pkg/container/list/list.go (right):

https://codereview.appspot.com/6682046/diff/3/src/pkg/container/list/list.go#...
src/pkg/container/list/list.go:179: // PushBackList inserts a copy of an other
list at the back of list l.
another?

http://english.stackexchange.com/questions/56435/an-other-vs-another

[taj, 2012-10-16 08:44:19]

Hello golang-dev@googlegroups.com, fullung@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[dfc, 2012-10-16 10:14:18]

LGTM. 

On 14/10/2012, at 3:51, taj.khattra@gmail.com wrote:

> Reviewers: golang-dev_googlegroups.com,
> 
> Message:
> Hello golang-dev@googlegroups.com,
> 
> I'd like you to review this change to
> https://go.googlecode.com/hg/
> 
> 
> Description:
> container/list: fix typo
> 
> Please review this at http://codereview.appspot.com/6682046/
> 
> Affected files:
>  M src/pkg/container/list/list.go
> 
> 
> Index: src/pkg/container/list/list.go
> ===================================================================
> --- a/src/pkg/container/list/list.go
> +++ b/src/pkg/container/list/list.go
> @@ -176,7 +176,7 @@
>    l.insert(l.remove(e), l.root.prev)
> }
> 
> -// PuchBackList inserts a copy of an other list at the back of list l.
> +// PushBackList inserts a copy of an other list at the back of list l.
> // The lists l and other may be the same.
> func (l *List) PushBackList(other *List) {
>    l.lazyInit()
> 
> 

[minux1, 2012-10-16 10:33:24]

https://codereview.appspot.com/6682046/diff/8001/src/pkg/container/list/list.go
File src/pkg/container/list/list.go (left):

https://codereview.appspot.com/6682046/diff/8001/src/pkg/container/list/list....
src/pkg/container/list/list.go:179: // PuchBackList inserts a copy of an other
list at the back of list l.
the word "other" here refers to the name of the argument.
i suggest we don't change it.

[dfc, 2012-10-16 10:34:23]

Oh, yes. Sorry I was looking at an old patchset, please revert the an other ->
other change.

[taj, 2012-10-17 04:15:37]

Hello golang-dev@googlegroups.com, fullung@gmail.com, dave@cheney.net,
minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

Please take another look.

[minux1, 2012-10-17 07:17:54]

LGTM.

[taj, 2012-10-28 04:51:31]

ping

[nigeltao, 2012-10-28 10:23:18]

Submitted.

[khr, 2013-06-04 21:55:17]

R=close