code review 6681044: log/syslog: build on Plan 9 and Windows

log/syslog: build on Plan 9 and Windows

This allows logging errors to a local or remote syslog
daemon over any protocol except Unix domain sockets.

[ality, 2012-10-13 03:20:29]

Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[ality, 2012-10-13 04:00:30]

Hello alex.brainman@gmail.com (cc: golang-dev@googlegroups.com),

Please take another look.

[minux1, 2012-10-13 07:16:03]

https://codereview.appspot.com/6681044/diff/6001/src/pkg/log/syslog/syslog_te...
File src/pkg/log/syslog/syslog_test.go (right):

https://codereview.appspot.com/6681044/diff/6001/src/pkg/log/syslog/syslog_te...
src/pkg/log/syslog/syslog_test.go:5: // +build !windows,!plan9
perhaps change the build tags here?

https://codereview.appspot.com/6681044/diff/6001/src/pkg/log/syslog/syslog_wi...
File src/pkg/log/syslog/syslog_windows.go (left):

https://codereview.appspot.com/6681044/diff/6001/src/pkg/log/syslog/syslog_wi...
src/pkg/log/syslog/syslog_windows.go:8: // BUG(brainman): This package is not
implemented on Windows yet.
please don't remove this file.
as windows have its own way of syslog, we need to support that in this package.

[mikio, 2012-10-13 16:26:07]

s/syslog_notunix.go/syslog_stub.go/ or
split syslog_notunix.go into syslog_windows.go and syslog_plan9.go.

[brainman, 2012-10-15 03:52:00]

I do not have problem with this change, but Russ might. We had this discussion
before: http://code.google.com/p/go/issues/detail?id=1108. I think we should
wait for his input before proceeding.

Alex

[ality, 2012-11-08 03:53:37]

On 2012/10/15 03:52:00, brainman wrote:
> I do not have problem with this change, but Russ might. We had this discussion
> before: http://code.google.com/p/go/issues/detail?id=1108. I think we should
> wait for his input before proceeding.
> 
> Alex

Thanks for the reference.

[rsc, 2012-11-26 19:14:13]

I don't believe this is right. I would like log/syslog to talk to the standard
host OS logging, whatever that is. So on Plan 9 it would be like calling
syslog(3), and on Windows, well, whatever Windows does.

[ality, 2013-01-07 23:10:39]

*** Abandoned ***