Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(174)

Issue 6674047: code review 6674047: cmd/gc: don't squash complex literals when inlining. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by remyoudompheng
Modified:
11 years, 5 months ago
Reviewers:
CC:
golang-dev, rsc, remy_archlinux.org
Visibility:
Public.

Description

cmd/gc: don't squash complex literals when inlining. Since this patch changes the way complex literals are written in export data, there are a few other glitches. Fixes issue 4159.

Patch Set 1 #

Patch Set 2 : diff -r a3af77cc3fcd https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a3af77cc3fcd https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r d588fe3d90c8 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -643 lines) Patch
M src/cmd/gc/fmt.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/go.y View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/gc/y.tab.h View 1 5 chunks +28 lines, -8 lines 0 comments Download
M src/cmd/gc/y.tab.c View 1 281 chunks +375 lines, -632 lines 0 comments Download
M src/pkg/exp/types/gcimporter.go View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/pkg/exp/types/staging/gcimporter.go View 1 2 chunks +2 lines, -1 line 0 comments Download
A test/fixedbugs/bug466.go View 1 1 chunk +11 lines, -0 lines 0 comments Download
A test/fixedbugs/bug466.dir/a.go View 1 1 chunk +15 lines, -0 lines 0 comments Download
A test/fixedbugs/bug466.dir/b.go View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4
remyoudompheng
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, remy@archlinux.org), I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 5 months ago (2012-10-13 11:21:59 UTC) #1
remyoudompheng
Alternatively we could keep the format and fix the parser when reading exported inlinable code, ...
11 years, 5 months ago (2012-10-13 11:22:40 UTC) #2
rsc
LGTM
11 years, 5 months ago (2012-10-16 17:25:20 UTC) #3
remyoudompheng
11 years, 5 months ago (2012-10-17 18:33:49 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=11f0ba3b7006 ***

cmd/gc: don't squash complex literals when inlining.

Since this patch changes the way complex literals are written
in export data, there are a few other glitches.

Fixes issue 4159.

R=golang-dev, rsc
CC=golang-dev, remy
http://codereview.appspot.com/6674047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b