code review 66600043: cmd/go: Plan 9 compatible "env" output

cmd/go: Plan 9 compatible "env" output

Fixes the output of go env so that variables can be set
more accurately when using Plan 9's rc shell.  Specifically,
GOPATH may have multiple components and the current
representation is plain wrong.  In practice, we porobably
ought to change os.Getenv to produce the right result, but
that requires considerably more thought.

[lucio, 2014-02-20 16:48:54]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gobot, 2014-02-24 15:10:52]

R=rsc@golang.org (assigned by rsc@golang.org)

[rsc, 2014-02-24 16:48:13]

LGTM

[0intro, 2014-02-24 18:49:09]

*** Submitted as https://code.google.com/p/go/source/detail?r=ba599658e88e ***

cmd/go: Plan 9 compatible "env" output

Fixes the output of go env so that variables can be set
more accurately when using Plan 9's rc shell. Specifically,
GOPATH may have multiple components and the current
representation is plain wrong. In practice, we probably
ought to change os. Getenv to produce the right result, but
that requires considerably more thought.

LGTM=rsc
R=golang-codereviews, gobot, rsc
CC=golang-codereviews
https://codereview.appspot.com/66600043

Committer: David du Colombier <0intro@gmail.com>

[gobot, 2014-02-24 21:05:58]

This CL appears to have broken the windows-386-ec2 builder.

[lucio, 2014-02-25 04:20:47]

Is this for real?  I can't see how it would.

Lucio.


On 2/24/14, gobot@golang.org <gobot@golang.org> wrote:
> This CL appears to have broken the windows-386-ec2 builder.
>
> https://codereview.appspot.com/66600043/
>

[dfc, 2014-02-25 04:31:47]

It's not a real build failure, the windows builder timed out and was
considered to fail.


On Tue, Feb 25, 2014 at 3:20 PM, Lucio De Re <lucio.dere@gmail.com> wrote:

> Is this for real?  I can't see how it would.
>
> Lucio.
>
>
> On 2/24/14, gobot@golang.org <gobot@golang.org> wrote:
> > This CL appears to have broken the windows-386-ec2 builder.
> >
> > https://codereview.appspot.com/66600043/
> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[lucio, 2014-02-25 04:52:14]

I know all about that, all my platforms have that problem :-)

Thanks for the reassurance.

Lucio.


On 2/25/14, Dave Cheney <dave@cheney.net> wrote:
> It's not a real build failure, the windows builder timed out and was
> considered to fail.
>
>
> On Tue, Feb 25, 2014 at 3:20 PM, Lucio De Re <lucio.dere@gmail.com> wrote:
>
>> Is this for real?  I can't see how it would.
>>
>> Lucio.
>>
>>
>> On 2/24/14, gobot@golang.org <gobot@golang.org> wrote:
>> > This CL appears to have broken the windows-386-ec2 builder.
>> >
>> > https://codereview.appspot.com/66600043/
>> >
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "golang-codereviews" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-codereviews+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>