Issue 66550044: cloudinit: Use curl instead of wget. Fix #1282553

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 66550044: cloudinit: Use curl instead of wget. Fix #1282553 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by dimitern

Modified:
10 years, 2 months ago

Reviewers:
mp+207443, gz

Visibility:
Public.

Description

cloudinit: Use curl instead of wget. Fix #1282553 As mentoned in the bug, wget on precise does not support SNI an cURL does, so this changes cloudinit to install curl and use it instead of wget to fetch the tools from streams.canonical.com on bootstrap. Live tested on EC2 and MAAS. https://code.launchpad.net/~dimitern/juju-core/301-lp-1282553-use-curl-not-wget-precise/+merge/207443 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : cloudinit: Use curl instead of wget. Fix #1282553 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM. https://codereview.appspot.com/66550044/diff/1/environs/cloudinit/cloudinit.go File environs/cloudinit/cloudinit.go (right): https://codereview.appspot.com/66550044/diff/1/environs/cloudinit/cloudinit.go#newcode249 environs/cloudinit/cloudinit.go:249: c.AddPackage("curl") Is curl really not installed in the ...

10 years, 2 months ago (2014-02-20 14:11:36 UTC) #2

dimitern

10 years, 2 months ago (2014-02-20 15:50:22 UTC) #3

Please take a look.

https://codereview.appspot.com/66550044/diff/1/environs/cloudinit/cloudinit.go
File environs/cloudinit/cloudinit.go (right):

https://codereview.appspot.com/66550044/diff/1/environs/cloudinit/cloudinit.g...
environs/cloudinit/cloudinit.go:249: c.AddPackage("curl")
On 2014/02/20 14:11:36, gz wrote:
> Is curl really not installed in the base cloud image on precise?

I was not certain, that's why I preferred to add it, just in case.
But as Adam confirmed on IRC curl is indeed in the cloud image for precise, so
removed.

Expand All Messages | Collapse All Messages